Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Import of VCard fails, I/O error reported #13514

Closed
Trapfether opened this issue Aug 12, 2020 · 5 comments
Closed

Import of VCard fails, I/O error reported #13514

Trapfether opened this issue Aug 12, 2020 · 5 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download S3 Blocks non-critical functionality and a work around exists

Comments

@Trapfether
Copy link

Trapfether commented Aug 12, 2020

When downloading and opening a vCard, the file is somehow changed in a way that Contacts no longer recognizes it and causes a failure. I have verified that the same exact file when opened directly from the phone's download folder imports as expected.

Open https://www.phpclasses.org/browse/file/5543.html and download the example vCard

When the notification appears, attempt to "Open" the vCard

The phone's usual contact import process should take over and import the vCard into contacts.

Instead, the contacts app displays an error saying the vCard cannot be imported, even though the same file can be imported from the devices "Downloads" folder

I am using

Google Pixel 1
Android 10 Build QP1A.191005.007.A3
I Am using Firefox for android 68.11.0

┆Issue is synchronized with this Jira Task

@Trapfether Trapfether added the 🐞 bug Crashes, Something isn't working, .. label Aug 12, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 12, 2020
@liuche
Copy link
Contributor

liuche commented Aug 15, 2020

I wonder if we need to support some kind of filetype on the AC side @Amejia481 for these kinds of downloads? What do we do for files that the Android system doesn't automatically support?

I tried opening the vCard from the Files app on my phone, and it opened in Google Drive (which couldn't open it) but suggested a different way of opening the file (which then triggered a Contacts permission).

Mostly I'm curious if there is an easy fix (like exposing a different filetype) so we can prioritize this against other downloads bugs.

@liuche liuche added Feature:Download and removed needs:triage Issue needs triage labels Aug 15, 2020
@Amejia481
Copy link
Contributor

I wonder if we need to support some kind of filetype on the AC side @Amejia481 for these kinds of downloads? What do we do for files that the Android system doesn't automatically support?

I tried opening the vCard from the Files app on my phone, and it opened in Google Drive (which couldn't open it) but suggested a different way of opening the file (which then triggered a Contacts permission).

Mostly I'm curious if there is an easy fix (like exposing a different filetype) so we can prioritize this against other downloads bugs.

We have to investigate to see what's happening, as we are creating a generic intent using the content type provided as the download's metadata. As other apps, can open the file, it's very likely to be something that we missing in the intent creation. Assessing the issue should not be that intensive to find.

@Amejia481
Copy link
Contributor

Very likely to be fixed after mozilla-mobile/android-components#9558 lands similar to #17502

@Amejia481 Amejia481 added the S3 Blocks non-critical functionality and a work around exists label Feb 1, 2021
@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Feb 17, 2021
@ebalazs-sv
Copy link

Verified as fixed on Nightly 2/19 GV 87 with Pixel 2 (Android 9).
The issue is still reproducible on Beta 86.0.0-beta.5 GV 86 from 2/15 and Release 86.1.0-rc.1 GV 86 from 2/16.
I will remove the qa:needed label and close this issue.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 19, 2021
@Amejia481
Copy link
Contributor

Thanks @ebalazs-sv

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Development

No branches or pull requests

4 participants