Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] The close button, "X" for Download notification needs resizing #14726

Closed
Diana-Rus opened this issue Sep 4, 2020 · 2 comments
Closed

[Bug][a11y] The close button, "X" for Download notification needs resizing #14726

Diana-Rus opened this issue Sep 4, 2020 · 2 comments
Assignees
@codrut-topliceanu
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download Feature:Notifications S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@Diana-Rus
Copy link

Diana-Rus commented Sep 4, 2020 •
edited by data-sync-user
Loading

Prerequisites

  • Have Google Accessibility Scanner installed.
  • Have a clean Firefox profile.

Steps to reproduce

  1. Open app and navigate to thinkbroadband.com/download
  2. Choose to download a file and wait until download prompt is displayed.
  3. Scan the screen.

Expected behavior

There are no suggestions to make any changes.

Actual behavior

Touch target
org.mozilla.fenix:id/close_button
This item's size is 24dp x 24dp. Consider making this touch target 48dp wide and 48dp high or larger.

Device information

  • Android device: Google Pixel 3XL (A9)
  • Fenix version: Nightly 9/4

screenshot_Firefox Nightly_org mozilla fenix_id-close_button_17179869186_2020-09-04-16_13_06

Note: issue similar to #7754

┆Issue is synchronized with this Jira Task
@Diana-Rus Diana-Rus added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:Download labels Sep 4, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 4, 2020
@Diana-Rus Diana-Rus added Feature:Notifications and removed needs:triage Issue needs triage labels Sep 4, 2020
@codrut-topliceanu codrut-topliceanu self-assigned this Sep 8, 2020
This was referenced Sep 8, 2020
Closed
Merged
@codrut-topliceanu
Copy link
Contributor

Will be fixed by mozilla-mobile/android-components#8351

@sflorean
Copy link
Contributor

Verified as fixed on Nightly 17/11 with Pixel 3 (Android 11) and LG G7 FIT (Android 8), no suggestions are made to increase the size dot "X" button.

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codrut-topliceanu codrut-topliceanu

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download Feature:Notifications S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Diana-Rus @sflorean @codrut-topliceanu