Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Optimize gesture settings #15629

Closed
Mugurell opened this issue Oct 2, 2020 · 10 comments
Closed

Optimize gesture settings #15629

Mugurell opened this issue Oct 2, 2020 · 10 comments
Labels

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Oct 2, 2020

As a followup up to #10240 and #13442, based on UX feedback the Gestures settings group should be phased out.

#13442 (comment):

An update from UX on this from @mheubusch:

  1. Pull to refresh: when it is ready it can go to release, NO setting to control it
    Pull to refresh is a default for many Android browsers. Here, we are shipping something to catch up to their feature set. Because it’s shipped with so many browsers, we think that people would not only expect pull to refresh to be a default behaviour. We also think that they don’t want to turn it off. So we should ship this gesture to Release, and not create a setting for it.

  2. Dynamic/Pinned toolbar: when this is ready it can go to Release, with a setting under "Toolbar" section
    Hide address bar on scroll is a default for us and many other Android browsers. Some contributors wanted the address bar to always show, independent of scrolling. That’s fine. We can ship it on release, but we won’t make this persistent toolbar behaviour a default. It will be controllable under Toolbar Settings.

  3. Swipe toolbar up for Tabs Tray Swipe up the bottom bar to see the tab menu #11862: this feature should stay on Nightly, but we can include a setting
    Other gestures control more advanced features. For example: swipe left/right on address bar to switch tabs. So far, we only received a signal that people want this feature through our contributors. But they’re not our general audience. So let’s hold off on shipping these other gestures, and keep them only in Nightly.

  4. Swipe toolbar left/right to switch tabs: TBD (since it is already in release)

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 2, 2020
@Mugurell
Copy link
Contributor Author

Mugurell commented Oct 2, 2020

I'm not quite sure about the timeline for this changes regarding release channels .
Should the changes be implemented right away and then depending on feature availability be uplifted to Release?

Currently Release doesn't have the new Gestures settings group. I understand we should hold it off of Release.

@liuche ?

@Mugurell
Copy link
Contributor Author

Mugurell commented Oct 2, 2020

Regarding

  1. Swipe toolbar up for Tabs Tray Swipe up the bottom bar to see the tab menu #11862: this feature should stay on Nightly, but we can include a setting
    Other gestures control more advanced features. For example: swipe left/right on address bar to switch tabs.

Can we get a mockup & strings?
@betsymi @mheubusch

@Mugurell Mugurell added needs:UX-feedback Needs UX Feedback and removed needs:triage Issue needs triage labels Oct 2, 2020
@apbitner
Copy link

@betsymi Let me know if any mocks are needed, happy to help.

@betsymi
Copy link

betsymi commented Oct 15, 2020

For Nightly only, this can go under Gestures on the Customize screen and the string is: Swipe toolbar up to view tabs

Attached the screenshot of our current Customize screen for reference.
Screenshot_20201015-151126

@maxstarkenburg
Copy link

Please forgive that I'm not familiar enough with the mozilla-mobile ecosystem to know why, for example, this issue is open, #10240 is closed, and in any case, I still don't see a setting to pin my toolbar in my Android Firefox (apparently I'm on 81.1.4). Do I need to instead be using one of the non-stable Android FF apps to be able to enable this?? (I hate the moving toolbar, and it's the reason that for the past couple of months I've made another browser my default (Brave, where it's also somewhat dynamic, but is less obnoxious about how quickly the disappearance/reappearance comes into effect after scrolling starts).)

I also feel a need to express my dismay at some of the quotes I'm reading in this issue's OP. Please remember that "other browsers do it, so we should do it to" is the exact opposite of why some of us have always loved and used Firefox. Please stop trying to be Chrome/Google. Please let users continue to customize/improve/extend and otherwise have some control over our browsing experience. Thanks.

@liuche
Copy link
Contributor

liuche commented Oct 20, 2020

Hi @maxstarkenburg, thanks for comment, we're working this bug, and you can see the code commits linked within this bug.

We land our changes on Nightly, but sometimes, in the case of #10240 we find that there are unexpected side effects, so additional work is needed.

The feature to prevent dynamic scrolling of the toolbar is a little complicated because of all the ways that the toolbar can be customized and also interact with the web content - rest assured, we're actively working on this and please be patient.

@B0pol
Copy link

B0pol commented Oct 21, 2020

Yeah I agree with @maxstarkenburg, other browsers do it is not a valid reason

Because it’s shipped with so many browsers, we think that people would not only expect pull to refresh to be a default behaviour. We also think that they don’t want to turn it off.

No, you are Firefox and your browsers are known to be customizable. And you still advertise Firefox for Android as customizable:

https://play.google.com/store/apps/details?id=org.mozilla.firefox&hl=en_US&gl=US

This version of the Firefox web browser is dramatically redesigned to be faster, easy to use, customizable and private.

Then why would you remove some customization?

@andreicristianpetcu
Copy link

Pull to refresh always gets in the way of scrolling on all browsers. I'm forcing myself to use it until it gets removed but I constantly trgger a refresh by mistake.
I know Chrome users want it but it's going to be another round of bad reviews in Play store 😞

@B0pol
Copy link

B0pol commented Oct 30, 2020

Last time I argued about Firefox and customisation, basically against

Because it’s shipped with so many browsers

But I did not really argued about the second point:

We also think that they don’t want to turn it off.

Please have a look at this Google support thread, when the preference to disable it was removed in Chrome 75

https://support.google.com/chrome/thread/8152831

There are 1771 upvotes and 223 comments to this date. And this is only the google support thread, not mentioning duplicates, other forums, other social medias…

Some users even mentioned switching to Firefox because of this:

Thank you Google for giving me the push needed to move over to Mozilla.

https://support.google.com/chrome/thread/8152831?msgid=8911501

[…] Removing Chrome and using Firefox

https://support.google.com/chrome/thread/8152831?msgid=8982682

https://support.google.com/chrome/thread/8152831?msgid=9402830

You car read the full thread and find other examples.

Also, Bromite, a popular Chromium Android fork added it back

-> This clearly shows you are wrong, users want to be able to turn off pull to refresh

@stale
Copy link

stale bot commented Apr 29, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 29, 2021
@stale stale bot closed this as completed May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants