Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Deleting an exception from ETP doesn't restore the cross-out shield #16670

Closed
lobontiumira opened this issue Nov 20, 2020 · 9 comments
Closed

[Bug] Deleting an exception from ETP doesn't restore the cross-out shield #16670

lobontiumira opened this issue Nov 20, 2020 · 9 comments
Assignees
@Amejia481
Labels
b:etp Issues caused by enhanced tracking protection 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified S3 Blocks non-critical functionality and a work around exists

Comments

@lobontiumira
Copy link

lobontiumira commented Nov 20, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open any website.
  2. Switch off the ETP toggle from the site security info panel.
  3. In the same info panel, tap on Protection Settings -> ETP page -> Exceptions.
  4. Remove the exception from the list.
  5. Tap back until you reach the website from step 1, and observe the ETP shield.

Expected behavior

The shield isn't crossed-out anymore. Tapping on it displays the security info panel with the active ETP toggle.

Actual behavior

The shield is still crossed-out. BUT, tapping on it displays the security info panel with the active ETP toggle.
Refreshing the page resolves the issue.

Device information

  • Android device: Samsung Galaxy Tab S6 (Android 10)
  • Fenix version: 11/18 Nightly, RC 83.1.0, and Beta 84.0.0-beta.1

┆Issue is synchronized with this Jira Task
@lobontiumira lobontiumira added 🐞 bug Crashes, Something isn't working, .. b:etp Issues caused by enhanced tracking protection labels Nov 20, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 20, 2020
@abodea abodea added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels Nov 20, 2020
@Amejia481 Amejia481 self-assigned this Nov 20, 2020
@s-ankur
Copy link
Contributor

s-ankur commented Nov 23, 2020

Similar #7929

@Amejia481
Copy link
Contributor

@s-ankur and @softvision-miralobontiu are you able to reproduce consistently? I was trying with Nightly 201130 17:01 (Build #2015778699) and I wasn't able to reproduce.

@lobontiumira
Copy link
Author

@Amejia481 I was able to reproduce again today, on the 12/2 Nightly build, with Samsung Galaxy Tab S6 (Android 10).

@Amejia481
Copy link
Contributor

Thanks, is it only reproducible consistently in this device or are there others? I was testing on a Pixel 3 with Android 11 and I had a hard time trying to reproduce, I was looking to see if there are any additional steps to reproduce or it's happening in certain devices.

@lobontiumira
Copy link
Author

No, I am able to reproduce it also on HTC 10 (Android 8), and on Sony Xperia Z5 Premium (Android 7.1.1).

@Amejia481 Amejia481 added S3 Blocks non-critical functionality and a work around exists and removed S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Dec 2, 2020
@Amejia481
Copy link
Contributor

Thanks for the info, I will try with Android 8 , 7 and 10.
I changed to S3 as the bug is not blocking any main functionality, only UI issue. and the shield icon will show the right status when the pages change or reloads.

This was referenced Dec 2, 2020
Closed
Merged
@Amejia481
Copy link
Contributor

Thanks for all the info, I was able to replicate. The issue will be fixed after this patch lands mozilla-mobile/android-components#9110 and Fenix updates its ac version with the required changes on it.

@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Dec 7, 2020
@Amejia481
Copy link
Contributor

I should be ready for QA review, I wasn't able to reproduce in nightly

@lobontiumira
Copy link
Author

Verified as fixed on the 12/10 Nightly build with Samsung Galaxy Tab S6 (Android 10), Google Pixel (Android 10), and OnePlus 5T (Android 9).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
b:etp Issues caused by enhanced tracking protection 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Amejia481 @s-ankur @lobontiumira @abodea