downloaded file has bin extension instead of opensudoku

[maurerle]

Downloading new sudokus for the opensudoku app from their website:
https://opensudoku.moire.org/ downloads a file with bin extension instead of opensudoku extension which is why it can not get recognized by the app.

Steps to reproduce

1. Open https://opensudoku.moire.org/sudoku/easy.opensudoku in Fennec Android downloaded from F-Droid
2. Downloaded file gets saved as easy.bin instead of easy.opensudoku

Expected behavior

File gets saved as easy.opensudoku

Actual behavior

Device information

• Android device: Redmi Note 7 lavender (reproduced on a samsung too)
• Fenix version: Fennec 84.1.2 from F-Droid

┆Issue is synchronized with this Jira Task

[sflorean]

I wasn't able to reproduce the issue on Nightly 30/12 with Xiaomi Redmi Note 8T (Android 9).

[maurerle]

I just downloaded Firefox for Android Beta from the Play Store which is Version 85.0.0-beta.4 and could reproduce the issue on Android 10.
The other device which reproduced the issue is also running on Android 10?

[maurerle]

Just tested current Firefox Nightly 201229 and could also reproduce the issue

[sflorean]

Thanks @maurerle for the extra info, I was able to reproduce it on an Android 10 devices.

[maurerle]

The .bin extension seems to come from here:
https://github.com/mozilla-mobile/android-components/blob/51bd9843331f62f63cdef5f9c98361198158c67d/components/support/utils/src/main/java/mozilla/components/support/utils/DownloadUtils.kt#L148-L152

It is unclear to me why this code branch is taken as the filename obviously contains a dot?

the mime-type of the file is [application/octet-stream]

[evilpie]

I suspect what might happen is that changeExtension changes the extension for files with the MIME type application/octet-stream. @Amejia481

[Amejia481]

Thanks for the report I added the issue to our backlog

[Amejia481]

The fix should be in master, QA team please help us to verify. Thanks in advance!

[Amejia481]

I suspect what might happen is that changeExtension changes the extension for files with the MIME type application/octet-stream. @Amejia481

The problem was that we were not considering generic MIME types you can see more details on mozilla-mobile/android-components#9526 and mozilla-mobile/android-components#9526 :)

[maurerle]

Thanks @Amejia481! when will the fix be available in Firefox Nightly?

[Amejia481]

It should be available in the next update. You can check the version by going to Settings -> About Firefox Nightly the AC version should be 73.0.20210128143151 or higher

[maurerle]

Yes its working now. Tested with current Firefox Nightly.
Thank you!

[sflorean]

I can confirm that this is also fixed in latest Nightly builds. Closing as verified.