Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Screenshot is not blocked when starting the app #17854

Closed
Mugurell opened this issue Feb 5, 2021 · 5 comments
Closed

[Bug] Screenshot is not blocked when starting the app #17854

Mugurell opened this issue Feb 5, 2021 · 5 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 5, 2021

The Settings -> Private browsing -> Allow screenshots in private mode is not enforced when starting the app.
If putting the app to background and resuming it (in most cases) the screenshots are blocked - as it should have happened from the beginning.

Steps to reproduce

Have Settings -> Private browsing -> Allow screenshots in private mode disabled

  1. Open the app and go tot the private tabs screen

    • Optional step: Open the list of open tabs in tabs tray
    • Take a screenshot
  2. Come back to app homescreen from a private tab

    • Optional step: Open the list of open tabs in tabs tray
    • Take a screenshot

Expected behavior

  • A message from Android saying that screenshots are not allowed

Actual behavior

  • Screenshots are possible

To note

When putting the app in background and resuming the FLAG_SECURE gets set (not all the times) so now one cannot take record the screen while in private mode.

Video showing these cases (use the android message / screenshot as indicators of when screenshots are blocked or not):

FLAG_SECURE.not.enforced3.mov

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. Feature:PrivateBrowsing labels Feb 5, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 5, 2021
@Mugurell Mugurell removed the needs:triage Issue needs triage label Feb 5, 2021
@Mugurell Mugurell added the S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist label Feb 5, 2021
@ekager ekager added the eng:qa:needed QA Needed label Feb 5, 2021
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 2/10 with LG G7 (Android 8.1.0)

@Nickoriginal
Copy link

Nickoriginal commented Jul 1, 2021

Reproducible in Firefox 89.1.1, 90.0.0-beta.6 and Nightly 91.0a1 2021-06-30T17:07:09.023

2021-07-01_09-20-37_001.mp4
2021-07-01_09-58-12_001.mp4
2021-07-01_09-55-52_001.mp4

@Nickoriginal
Copy link

@Mugurell, you can confirm this bug on your device(s), and, if possible, reopen it?

@Mugurell
Copy link
Contributor Author

Mugurell commented Jul 1, 2021

I see that screenshots are blocked in the browser (which this ticket was for)
but not in the tabs tray, for which we have an open ticket - #17855

@Nickoriginal
Copy link

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

No branches or pull requests

4 participants