Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Editing a custom search engine has slow response on Save #23536

Closed
sv-ohorvath opened this issue Feb 2, 2022 · 6 comments
Closed

Editing a custom search engine has slow response on Save #23536

sv-ohorvath opened this issue Feb 2, 2022 · 6 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Feb 2, 2022

Steps to reproduce

  1. Go to Settings>Search.
  2. Add a new custom search engine. Save
  3. Edit the new engine: change its title.
  4. Press Save.

Expected behaviour

Changes saved. Returns to Search engines list.

Actual behaviour

Sometimes nothing happens for a long while. I tapped the button a few times and no result.
Sometimes it works instantly, or after a short wait.

Device name

Pixel 2

Android version

Android 9

Firefox release type

Firefox

Firefox version

Release 97.1.0, Nightly 98.0a1

Device logs

Nothing appears in the logs while tapping the button.

Additional information

20220202_171742

┆Issue is synchronized with this Jira Task

@sv-ohorvath sv-ohorvath added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage Feature:Search S3 Blocks non-critical functionality and a work around exists labels Feb 2, 2022
@jonalmeida
Copy link
Contributor

Sometimes nothing happens for a long while. I tapped the button a few times and no result.
Sometimes it works instantly, or after a short wait.

@sv-ohorvath When adding a search engine, we need to try and connect to it first to verify we can make queries to it (we send out a search query for "1" and you can see this in about:debugging). So the save might be taking a while because the search engine site is slow to respond. This is another candidate for discussion in #23521 I think.

@jonalmeida
Copy link
Contributor

Ah, elefant.ro is a genuine e-commerce site, so if every UI test run is making a request to it from Firebase, we might have triggered their DDOS response and are now rate-limited or blocked from the Firebase IP addresses.

@sv-ohorvath
Copy link
Contributor Author

sv-ohorvath commented Feb 3, 2022

Ah, elefant.ro is a genuine e-commerce site, so if every UI test run is making a request to it from Firebase, we might have triggered their DDOS response and are now rate-limited or blocked from the Firebase IP addresses.

That is possible, just that the issue is reproducible in manual testing as well with that website.
I actually just tried 2 other websites and they were saved immediately. So it might be just something about that one.

@stale
Copy link

stale bot commented Nov 19, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 19, 2022
@sv-amocirean
Copy link

This issue is still reproducible on the latest Nightly of 24th of November 2022 (109.0a1). Tested using Samsung Galaxy S22 Ultra (Android 13) and Oppo Find X3 Neo (Android 11).
The slow response also occurs on adding the custom search engine.
Removing the wontfix label.

@stale stale bot removed the wontfix label Nov 24, 2022
@cpeterso cpeterso changed the title [Bug]: Editing a custom search engine has slow response on Save Editing a custom search engine has slow response on Save Dec 27, 2022
@cpeterso
Copy link

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807708

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Development

No branches or pull requests

4 participants