Fenix shouldn't show "Set as default browser" button if it's already the default browser

[cpeterso]

When I started Fenix Nightly today, its homepage had a tile asking me to set it as my default browser ("Set as default browser"). But Fenix Nightly is already my default browser!

@jonalmeida says Fenix should be able to check whether it's already set as the default app.

AC has code to query the default browser, but it might require some legacy permissions: [https://github.com/mozilla-mobile/android-components/blob/main/components/support/[…]tils/src/main/java/mozilla/components/support/utils/Browsers.kt.](https://github.com/mozilla-mobile/android-components/blob/ec0201897ae2b2d91ec36be41986dff1c3192501/components/support/utils/src/main/java/mozilla/components/support/utils/Browsers.kt#L112-L115)

┆Issue is synchronized with this Jira Task

[jonalmeida]

I can see we have the code for the app review prompt, but oddly enough, we do not use it for the button: https://searchfox.org/mozilla-mobile/search?q=isDefaultBrowser&path=fenix

[Amejia481]

Maybe this could be a regression from 82a6f8c, my nightly also shows the set to default browser banner on the home screen even though it's already the default browser.

cc @jhugman

[Amejia481]

This is what we use for checking on Fenix that internally uses AC.
But the value that we are using for FIREFOX_NIGHTLY is linked to fennec org.mozilla.fennec instead of org.mozilla.fenix

[Amejia481]

QA team could you help us to verify if this is still an issue, thanks in advance.

[SoftVision-LorandJanos]

I managed to reproduce this issue with the Nightly 98.0a1 (2022-02-06).
The banner was displayed while being set as default browser.
On the latest Nightly 99.0a1 (2022-02-15) I wasn't able to reproduce this issue.
Verified as fixed on the above mentioned Nightly.
Closing the ticket.