Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Media control notification #2551

Closed
vesta0 opened this issue May 16, 2019 · 20 comments
Closed

Media control notification #2551

vesta0 opened this issue May 16, 2019 · 20 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:FennecTransition Feature:Media needs:ac Needs Android Component Work
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented May 16, 2019

User Story

  • As a user playing audio/video in my browser, I want to see a persistent media notification when backgrounding the browser allowing me to pause/play playback at any time, so I have a visual indication of where audio is coming from and a way to control playback.

Also Note: Without a notification android will start de-prioritizing the browser causing sounds artifacts.

Acceptance Criteria

  • I can see a persistent media notification when I background my browser
  • I can see the title of the media playing in the notification
  • I can use the notification to pause/play playback

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to the Post-MVP Backlog milestone May 16, 2019
@vesta0 vesta0 added the P1 Current sprint label May 16, 2019
@vesta0 vesta0 changed the title Persistent notification when audio is playing in Fenix Persistent media control notification when audio is playing in Fenix Jul 2, 2019
@vesta0 vesta0 changed the title Persistent media control notification when audio is playing in Fenix Persistent media control notification Jul 2, 2019
@vesta0 vesta0 changed the title Persistent media control notification Media control notification Jul 2, 2019
@vesta0 vesta0 added must and removed P1 Current sprint labels Jul 2, 2019
@pocmo pocmo added the needs:ac Needs Android Component Work label Jul 3, 2019
@pocmo
Copy link
Contributor

pocmo commented Jul 3, 2019

@pocmo
Copy link
Contributor

pocmo commented Jul 11, 2019

A first iteration landed in RB and can be tested there. The notification does not contain any controls yet.

@topotropic topotropic removed their assignment Aug 23, 2019
@pocmo
Copy link
Contributor

pocmo commented Aug 23, 2019

leparisien.fr is also fixed with the latest snapshot.

frombelowpodcast.com needs more investigation.

@topotropic
Copy link

is it possible to send people to the tab where the audio/video is coming from when they tap on the notification? atm we just open the latest tab people where on.

@pocmo
Copy link
Contributor

pocmo commented Aug 28, 2019

@topotropic I'll file an AC issue for that. We can add the tab id to the Intent that opens the app and then we can add some code in Fenix that will switch to the right tab.

@colintheshots
Copy link
Contributor

@vesta0 Why was this moved back to In Progress? It seems the only remaining items for this feature are GV issues and feature requests. We should count it for the milestone, since the feature is in the release.

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Sep 6, 2019

This is not fixed yet.
No notifications were displayed. Pages tested: soundcloud.com, katai.ro, leparisien.fr, frombelowpodcast.com, on the latest Nightly 190821 (#12330640) with HTC Desire 820 (Android 6.0.1), OnePlus 5T (Android 9), and Sony Xperia Z2 Tablet (Android 6.0.1).

@colintheshots It looks like Mira found some issues here, but mistakenly added the "qa verified' label. If this fixed, I can help and retest if needed.

@pocmo
Copy link
Contributor

pocmo commented Sep 6, 2019

My recommendation is to close this issue, do another QA round to find new issues and verify the fixes, and then file bugs if we find new things (since this is shipping and not blocked).

Regarding the things that were already mentioned:

@pocmo pocmo added the eng:qa:needed QA Needed label Sep 6, 2019
@pocmo
Copy link
Contributor

pocmo commented Sep 6, 2019

  • frombelowpodcast.com -> Same GV issue as soundcloud

I debugged this a bit more and noticed some differences so I filed a separate GV bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1579390

@sv-ohorvath
Copy link
Contributor

Verified again on nightly 9/6 build. The issues mentioned above are fixed.
These are the new issues I've found:
#5151
#5154
Closing this bug as verified.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 6, 2019
@pocmo
Copy link
Contributor

pocmo commented Sep 6, 2019

Thank you, @sv-ohorvath! I'll look at those issues. :)

@data-sync-user data-sync-user changed the title Media control notification FNX2-18071 ⁃ Media control notification Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18071 ⁃ Media control notification FNX3-16404 ⁃ Media control notification Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16404 ⁃ Media control notification Media control notification May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:FennecTransition Feature:Media needs:ac Needs Android Component Work
Projects
None yet
Development

No branches or pull requests