Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] A page shortcut created in Private Mode should open in Private Mode and reflect this visually. #5341

Closed
klint opened this issue Sep 15, 2019 · 1 comment
Labels
🐞 bug Crashes, Something isn't working, .. Feature:PrivateBrowsing Feature:PWA Progressive Web App

Comments

@klint
Copy link

klint commented Sep 15, 2019

Steps to reproduce

Open Fenix in Private Mode (either directly by the new Private Mode Shortcut on homescreen, or by switching from Non-Private mode on Fenix home page).
Visit a page
Create a page shortcut on the homescreen by "Add to homescreen"

Expected behavior

The pop-ups to create the page shortcut should display the Private mode application icon.
The page shortcut on homescreen should display a small Private mode application icon in the corner.
The shortcut should open the page in Private mode, whatever mode was active previously

Actual behavior

The pop-ups to create the page shortcut display the Non-Private mode application icon.
The page shortcut on homescreen displays a small Non-Private mode application icon in the corner.
The shortcut opens the page in Non-Private mode if the applications was last open in Non-Private mode.

Device information

  • Android device: Redmi Note 7
  • Fenix version: Build 12580614

┆Issue is synchronized with this Jira Task

@liuche
Copy link
Contributor

liuche commented Oct 4, 2019

For now, to both minimize confusion (a user needs to remember which state they saved it in) and technical maintenance of another branch state, we're not doing this feature, because we've added a way for users to choose:
a) whether to open all links in Private Mode
b) if no default browser is set, to open in private or non-private in #5742 and #514

I know this doesn't exactly fix the issue you're asking for, but these are workarounds to allow you to choose how you open specific shortcuts, and we may revisit this issue in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:PrivateBrowsing Feature:PWA Progressive Web App
Projects
None yet
Development

No branches or pull requests

3 participants