[Bug] Crash when downloading Image

[csadilek]

We're getting this new relatively frequent crash:
https://sentry.prod.mozaws.net/operations/fenix-nightly/issues/6580864/

java.lang.IllegalArgumentException: Failed to find configured root that contains ...
    at androidx.core.content.FileProvider.getUriForFile(FileProvider.java:15)
    at mozilla.components.feature.prompts.MimeType$Image$1.invoke(MimeType.kt:2)
    at mozilla.components.feature.prompts.MimeType$Image.buildIntent(MimeType.kt:5)
    at mozilla.components.feature.prompts.FilePicker.handleFileRequest(FilePicker.kt:19)
    at mozilla.components.feature.prompts.PromptFeature.onPromptRequested$feature_prompts_release(PromptFeature.kt:4)
    at mozilla.components.feature.prompts.PromptFeature$start$1$invokeSuspend$$inlined$collect$1.emit(Collect.kt:7)
    at mozilla.components.support.ktx.kotlinx.coroutines.flow.FlowKt$ifAnyChanged$$inlined$filter$1$2.emit(Collect.kt:15)
    at mozilla.components.feature.prompts.PromptFeature$start$1$invokeSuspend$$inlined$map$1$2.emit(Collect.kt:5)

┆Issue is synchronized with this Jira Task

[sblatz]

This may be fixed in the newest version of AC, but we haven't gotten new snapshot for Fenix, so maybe it's just because we haven't gotten a new snapshot.

[cpeterso]

Corresponding Bugzilla bug filed from crash-stats: https://bugzilla.mozilla.org/show_bug.cgi?id=1595804

[sblatz]

Let's keep a pulse on this over the next few days but it seems to have disappeared?

[Amejia481]

I think the issue is still there, I able to reproduce it on master, the issue happens when the input has an image mime type.

STR:

1. Go https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file
2. Toggle Desktop site (to be set ON).
3. Tap browser button below the label "Choose a profile picture".

I'm taking a look to how to fix it. I will keep you update.

[Amejia481]

I think the main issue rely on feature-prompts and Fenix providers has the same authorities properties: android:authorities="${applicationId}.fileprovider"

Feature prompts
https://github.com/mozilla-mobile/android-components/blob/master/components/feature/prompts/src/main/AndroidManifest.xml

        <provider
            android:authorities="${applicationId}.fileprovider"
            android:name="androidx.core.content.FileProvider"
            android:exported="false"
            android:grantUriPermissions="true">
            <meta-data
                android:name="android.support.FILE_PROVIDER_PATHS"
                android:resource="@xml/file_paths" />
        </provider>

Fenix

fenix/app/src/main/AndroidManifest.xml

Line 252 in 7173bdf

<provider

        <provider
            android:name="androidx.core.content.FileProvider"
            android:authorities="${applicationId}.fileprovider"
            android:exported="false"
            android:grantUriPermissions="true">
            <meta-data
                android:name="android.support.FILE_PROVIDER_PATHS"
                android:resource="@xml/file_paths" />
        </provider>

[Amejia481]

Found the source of the issue the android:name="androidx.core.content.FileProvider" property is the same is both case and it should be unique.

[Amejia481]

This will fixed after #6699 lands

[lobontiumira]

Verified as fixed on the latest Nightly 11/25 (#13290608) with Google Pixel 3 (Android Q), and Huawei P9 Lite (Android 7).