Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Settings] Improve layout consistency across settings screens #7065

Closed
AmyYLee opened this issue Dec 10, 2019 · 8 comments
Closed

[Settings] Improve layout consistency across settings screens #7065

AmyYLee opened this issue Dec 10, 2019 · 8 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:quality An optional polish ticket that is nice to have eng:ready Ready for engineering Feature:Settings implementation review P2 Upcoming release

Comments

@AmyYLee
Copy link
Collaborator

AmyYLee commented Dec 10, 2019

Looking at our settings screens there are some inconsistency with alignments (mostly how we left align body copy).

Layout edits: https://share.goabstract.com/54f2c91a-46b3-4658-bd81-91c73a5c3ca4?mode=design&sha=db55e95ad5e27dbb1a5ad787a091fb7b60b5b416

┆Issue is synchronized with this Jira Task

@AmyYLee AmyYLee added 🐞 bug Crashes, Something isn't working, .. implementation review needs:group-triage labels Dec 10, 2019
@boek boek added eng:quality An optional polish ticket that is nice to have and removed needs:group-triage labels Dec 10, 2019
@AmyYLee AmyYLee added Feature:Settings eng:ready Ready for engineering labels Dec 10, 2019
@boek boek added the P2 Upcoming release label Dec 19, 2019
@liuche
Copy link
Contributor

liuche commented Mar 31, 2020

Ask @brampitoyo for UI review (since Bram will be taking over for Settings)

@brampitoyo brampitoyo self-assigned this Mar 31, 2020
@brampitoyo
Copy link

@liuche Just to be aware that we’re also improving layout consistency of Add-ons Manager and its sub-pages in #8520.

@hkaancaliskan
Copy link

hkaancaliskan commented Jun 26, 2020

@brampitoyo could you please share settings -> search ux mock. I can't see widths and margins etc with this one.
Actually let's share all of them that needs changes.

Edit: I mean like this ones that I can see the margins etc.
https://share.goabstract.com/d1d0bb78-03c9-4822-aea1-a553d2fd4944?mode=build&sha=72ed314cb3b094e510d264a18e99870147787fa0

@brampitoyo
Copy link

@hakkikaancaliskan I completed the layout edits for all sub-pages under the sections “Account” and “General”.

https://share.goabstract.com/2e7f2625-24e4-41e9-bb9b-5e78c31dbbbe?mode=design&sha=62825ec262f4d071a8acae25bec9180f84bf4d3d

I will finish the rest of the pages under the sections “Privacy and security”, “Advanced” and “About”. But note that all my fixes follow practically the same guideline: all list items have a keyline value of 72dp.

At the moment, you’ll note that our list items sometimes follow the keyline, and they sometimes don’t. Ideally, they all should.

Demonstration:

For further information, follow this link https://material.io/design/layout/spacing-methods.html#spacing and search for "keylines".

@hkaancaliskan
Copy link

@brampitoyo There is just #12691 left. I think we can close this issue after you check everything again.

@hkaancaliskan
Copy link

@brampitoyo Everything done.

@brampitoyo
Copy link

@hakkikaancaliskan I just finished reviewing #12691. Looks like our settings alignment work is all complete!

@hkaancaliskan
Copy link

@NotWoods this issue is done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:quality An optional polish ticket that is nice to have eng:ready Ready for engineering Feature:Settings implementation review P2 Upcoming release
Projects
None yet
Development

No branches or pull requests

6 participants