Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Meta] Reader Mode #74

Closed
1 of 3 tasks
bbinto opened this issue Nov 2, 2018 · 8 comments
Closed
1 of 3 tasks

[Meta] Reader Mode #74

bbinto opened this issue Nov 2, 2018 · 8 comments
Labels
needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready
Milestone

Comments

@bbinto
Copy link
Contributor

bbinto commented Nov 2, 2018

Why/User Benefit/User Problem

As a user, I want to have a clean and distraction free reading experience for long-form content (e.g. news articles)

What / Requirements

UX mocks: #190
User Stories (listed below)

Acceptance Criteria (how do I know when I’m done?)
-Complete all user stories
-Supporting perceived speed goals (See ideas here: https://arxiv.org/pdf/1811.03661.pdf)

GV dependencies:

A-C Dependencies:

https://github.com/orgs/mozilla-mobile/projects/25

┆Issue is synchronized with this Jira Task

@bbinto bbinto changed the title Reader Mode Evaluate Reader Mode Nov 2, 2018
@bbinto bbinto added this to the Milestone 1 milestone Nov 2, 2018
@bbinto bbinto self-assigned this Nov 2, 2018
@bbinto bbinto closed this as completed Jan 18, 2019
@bbinto bbinto reopened this Jan 21, 2019
@bbinto bbinto modified the milestones: UX Backlog, MVP Metas Jan 21, 2019
@bbinto bbinto changed the title Evaluate Reader Mode [Meta] Reader Mode Jan 21, 2019
@bbinto bbinto added the Epic label Jan 23, 2019
@bbinto bbinto added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jan 24, 2019
@bbinto
Copy link
Contributor Author

bbinto commented Jan 24, 2019

@Sdaswani: Need an engineer to do a technical analysis and provide possible options

@Sdaswani
Copy link

Sure @bbinto the research should be sprint planned, feel free to decide when to have an engineer do that.

@cpeterso
Copy link

There is still debate whether Reader View should be implemented in A-C or GV.

Here is the GV bug for Reader View:
https://bugzilla.mozilla.org/show_bug.cgi?id=1509257

Here is the A-C issue for Reader View:
mozilla-mobile/android-components#1346

Here is the R-B issue for Reader View:
mozilla-mobile/reference-browser#152

@cpeterso
Copy link

@snorp suggests that Reader View be implemented by A-C using a WebExtension to inject Readability.js as a content script.

@pocmo
Copy link
Contributor

pocmo commented Jan 30, 2019

@snorp suggests that Reader View be implemented by A-C using a WebExtension to inject Readability.js as a content script.

Note that if that is the preference then this is a large project for A-C and we would have to discuss timelines and priorities.

We will have at least a dependency on GV for providing the API for loading WebExtensions (looks like this work is happening already) and the WebExt API for having a communication channel between extension and app code.

@Sdaswani
Copy link

@pocmo is there an estimate if we implemented this in AC?

@pocmo
Copy link
Contributor

pocmo commented Jan 30, 2019

Not yet. But we can start breaking the linked A-C issue down based on snorp's suggestion.

@bbinto bbinto added the must label Jan 30, 2019
@bbinto bbinto assigned vesta0 and unassigned bbinto Feb 12, 2019
@vesta0 vesta0 added needs:ac Needs Android Component Work GV67 labels Mar 5, 2019
@bbinto
Copy link
Contributor Author

bbinto commented Mar 18, 2019

As per comment, we might pull this back into a Battery saving story after MVP, however it should land for MVP as an individual feature.

@vesta0 vesta0 added needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org and removed GV67 labels Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Development

No branches or pull requests

5 participants