Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Share from my installed PWA to other installed (native) apps #780

Closed
pocmo opened this issue Nov 29, 2018 · 6 comments
Closed

Share from my installed PWA to other installed (native) apps #780

pocmo opened this issue Nov 29, 2018 · 6 comments
Assignees
@NotWoods
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:PWA Progressive Web App

Comments

@pocmo
Copy link
Contributor

pocmo commented Nov 29, 2018 •
edited by data-sync-user
Loading

User Story

As a user, I want to share from my installed PWA to other installed (native) apps, so I can have a seamless share experience between apps.

Acceptance Criteria

-I can share from my installed PWA to other installed native apps.

Dependencies

Web Share API: https://developers.google.com/web/updates/2016/09/navigator-share
Android Components bug: mozilla-mobile/android-components#3486
GeckoView bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1402369

┆Issue is synchronized with this Jira Task
@andreasbovens
Copy link
Contributor

This will require DOM and GeckoView work.

@andreasbovens
Copy link
Contributor

https://bugzilla.mozilla.org/show_bug.cgi?id=1402369 is the bug for this work on the Platform side.

@st3fan st3fan transferred this issue from mozilla-mobile/reference-browser Mar 1, 2019
@pocmo pocmo mentioned this issue Mar 1, 2019
Closed
23 tasks
@bbinto bbinto mentioned this issue Mar 1, 2019
Closed
@vesta0 vesta0 added this to the Backlog (After MVP) milestone Mar 27, 2019
@vesta0 vesta0 added P2 Upcoming release and removed P2 Upcoming release Feature:PWA Progressive Web App labels Mar 28, 2019
@kbrosnan kbrosnan added the Feature:PWA Progressive Web App label Apr 29, 2019
@vesta0 vesta0 added P1 Current sprint and removed P2 Upcoming release labels May 17, 2019
@vesta0 vesta0 removed P1 Current sprint labels Jul 2, 2019
@sblatz sblatz added the feature request 🌟 New functionality and improvements label Jul 11, 2019
@vesta0 vesta0 removed this from the Feature Backlog milestone Jul 26, 2019
@NotWoods NotWoods added needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Aug 30, 2019
@NotWoods
Copy link
Contributor

Android Components bug: mozilla-mobile/android-components#3486
GeckoView bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1402369

@vesta0 vesta0 changed the title As a user I want to share from my installed PWA to other installed (native) apps Share from my installed PWA to other installed (native) apps Sep 27, 2019
@vesta0 vesta0 added should and removed feature request 🌟 New functionality and improvements labels Sep 27, 2019
@lime124 lime124 mentioned this issue Sep 27, 2019
Closed
8 tasks
@bbinto bbinto mentioned this issue Oct 6, 2019
Closed
4 tasks
@bifleming bifleming added the feature request 🌟 New functionality and improvements label Oct 9, 2019
@NotWoods NotWoods added E13 Estimation Point: about 10 days E3 Estimation Point: average, 2 - 3 days and removed E13 Estimation Point: about 10 days labels Oct 14, 2019
@NotWoods NotWoods removed needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Nov 4, 2019
@vesta0 vesta0 removed the feature request 🌟 New functionality and improvements label Nov 6, 2019
@NotWoods NotWoods added the eng:qa:needed QA Needed label Dec 10, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 11, 2019 •
edited
Loading

Hi @NotWoods ,not sure what is the proper way to test this, and would really appreciate your help. ☺️

I've checked this matter on the latest Nightly Build #13450608 from 12/11 using a Google Pixel 3 a (Android 9) and noticed the following while Trying to share from the 9GAG PWA:

►By tapping one by one on each of the featured 9GAG sharing options, a Fenix custom tab is opened
20191212_165153

►By tapping the "More button" the Android sharing options context menu shows up and sharing seems to be working to:
20191212_164004

►By long tapping on content (this is applicable only for pictures in this case, no Fenix context menu is opened for GIF's or Videos)
20191212_164320

Please review and let me know how should I check this matter.

@NotWoods
Copy link
Contributor

  1. Open a site that uses the Web Share API, such as https://web-share.glitch.me/.
  2. Initiate a share through the website, not browser UI (Use the "Share" button on that site).
  3. Depending on the share target,
    a. It should successfully share the text and URL when sent to an Android app (Check out this great poem about a Jabberwocky. https://en.wikipedia.org/wiki/Jabberwocky).
    b. It shoudl successfully share the title and URL when sending a tab.

@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 13, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 13, 2019

Hi, verified as fixed on the latest Nightly Build #13470611 from 12/13 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)

✔️ Twitter - Tweet
✔️ Twitter - DM
✔️ Facebook Messenger
✔️ Skype
✔️ WhatsApp

► Video
20191214_112708

@NotWoods Thanks for helping me out! ☺️

@AndiAJ AndiAJ closed this as completed Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NotWoods NotWoods

Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:PWA Progressive Web App
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@pocmo @kbrosnan @andreasbovens @NotWoods @sblatz @vesta0 @bifleming @AndiAJ