Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

[Meta] Screenshots #89

Closed
bbinto opened this issue Dec 3, 2018 · 9 comments
Closed

[Meta] Screenshots #89

bbinto opened this issue Dec 3, 2018 · 9 comments
Labels
feature request 🌟 New functionality and improvements needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org pin Issues, features, improvements that are still valid 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@bbinto
Copy link
Contributor

bbinto commented Dec 3, 2018 •
edited by data-sync-user
Loading

Requirements (user story to be written)

  • screenshot saved to your photos folder
  • screenshot saved to your Fenix library
  • options to save whole page, viewed area, a selection
  • URL, title of image properties
  • Integration screenshots

A-C: mozilla-mobile/android-components#1826

┆Issue is synchronized with this Jira Task
@Sdaswani Sdaswani changed the title Take screenshots of page [meta] Take screenshots of page Dec 6, 2018
@Sdaswani Sdaswani added this to the MVP Metas milestone Jan 18, 2019
@bbinto
Copy link
Contributor Author

bbinto commented Jan 18, 2019

UX issue: #183

@bbinto bbinto changed the title [meta] Take screenshots of page [meta] Screenshots Jan 22, 2019
@bbinto bbinto added the Epic label Jan 22, 2019
@pocmo pocmo mentioned this issue Jan 24, 2019
Closed
3 tasks
@bbinto bbinto added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jan 25, 2019
@bbinto
Copy link
Contributor Author

bbinto commented Jan 25, 2019

Need to confirm with GeckoView

@bbinto bbinto added the should label Jan 30, 2019
@cpeterso
Copy link

cpeterso commented Jan 31, 2019 •
edited
Loading

GV bugs for taking screenshots of web content:

@vesta0 vesta0 added the needs:ac Needs Android Component Work label Feb 13, 2019
@bbinto bbinto mentioned this issue Mar 1, 2019
Closed
@bbinto
Copy link
Contributor Author

bbinto commented Mar 13, 2019

@vesta0 - I'm considering dropping this for MVP partially after talking to GV engineering manager and workload vs other priorities. Thoughts?

@cpeterso
Copy link

cpeterso commented Mar 13, 2019 •
edited
Loading

GV support for taking viewport screenshots (for page thumbnails in tab switcher UI) has already landed (bug 1462018). Full page shots (bug 1530967) is still planned but it will be more work.

@bbinto
Copy link
Contributor Author

bbinto commented Mar 14, 2019

As discussed with @vesta0 - we could start with supporting viewport screenshot support for MVP if possible, but it should not be a MUST criteria. Keeping it on the board as a "could" seems reasonable.

@cpeterso
Copy link

As discussed with @vesta0 - we could start with supporting viewport screenshot support for MVP if possible, but it should not be a MUST criteria. Keeping it on the board as a "could" seems reasonable.

GV has support for viewport screenshots (for page thumbnails in tab switcher UI) has landed and is ready for the AC team to start using (android-components#498).

The GV API for full page shots (bug 1530967) is still planned but it will be more work.

@bbinto
Copy link
Contributor Author

bbinto commented Mar 15, 2019

Considering de-scoping this for MVP as there is no real additional / new user value than using the current screenshot device functionality, this also came out of some research findings lately. @vesta0 - do you agree?

@bbinto bbinto modified the milestones: MVP Metas, Backlog (After MVP) Mar 18, 2019
@bbinto bbinto changed the title [meta] Screenshots [Meta] Screenshots Mar 27, 2019
@vesta0 vesta0 removed the P2 Upcoming release label Mar 28, 2019
@vesta0 vesta0 added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Apr 17, 2019
@vesta0 vesta0 removed their assignment May 14, 2019
@vesta0 vesta0 removed the could label Jun 7, 2019
@vesta0 vesta0 added the P2 Upcoming release label Jun 26, 2019
@vesta0 vesta0 removed Epic P2 Upcoming release labels Jul 5, 2019
@sblatz sblatz added the feature request 🌟 New functionality and improvements label Jul 11, 2019
@vesta0 vesta0 removed this from the Feature Backlog milestone Jul 26, 2019
@data-sync-user data-sync-user mentioned this issue Aug 12, 2020
Closed
3 tasks
@hwinnemoe hwinnemoe mentioned this issue Sep 18, 2020
Closed
@JoGarWeb
Copy link

JoGarWeb commented Dec 5, 2020

Now this is forgotten 😭💔🥺

@amedyne amedyne added the pin Issues, features, improvements that are still valid label Jan 3, 2021
@cadeyrn cadeyrn mentioned this issue Mar 25, 2021
Closed
@mozilla-mobile mozilla-mobile locked and limited conversation to collaborators Jul 30, 2021
@amedyne amedyne closed this as completed Jul 30, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
feature request 🌟 New functionality and improvements needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org pin Issues, features, improvements that are still valid 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@bbinto @cpeterso @sblatz @Sdaswani @JoGarWeb @vesta0 @amedyne