Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fennec migration: The "Start Firefox" button is not visible in split view on devices with a smaller resolution #8924

Closed
ebalazs-sv opened this issue Feb 28, 2020 · 6 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Migration

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Feb 28, 2020

Preconditions:

Have Fennec installed.

Steps to reproduce

  1. Replace Fennec with Fenix using a build from here.
  2. With the onboarding migration screen displayed, long tap the Recent apps button;
  3. Observe the migration onboarding screen page;

Expected behavior

All the elements from the migration onboarding page are visible.

Actual behavior

The "Start Firefox" button is not visible in split view on devices with a smaller resolution.

Notes:

Screenshot in portrait mode;
Screenshot in landscape mode;
Not reproducible on LG G7 fit (Android 8.1), 1440 x 3120 pixels, 19.5:9 ratio (~563 ppi density);

Device information

  • Android device: Huawei P9 Lite (Android 7), resolution 1080 x 1920 pixels;
  • Fenix version: Beta migration build 2, 02/27.

┆Issue is synchronized with this Jira Task

@Sparky93 Sparky93 self-assigned this Mar 3, 2020
@Sparky93 Sparky93 transferred this issue from mozilla-mobile/android-components Mar 3, 2020
@Sparky93 Sparky93 added Feature:Migration 🐞 bug Crashes, Something isn't working, .. labels Mar 3, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 3, 2020
@Sparky93 Sparky93 removed the needs:triage Issue needs triage label Mar 3, 2020
@Sparky93
Copy link
Contributor

Sparky93 commented Mar 3, 2020

Tested with this PR from #7978 and it looks like a bottom anchored button is going to fix the problem.
image

@ebalazs-sv
Copy link
Author

ebalazs-sv commented Mar 5, 2020

This is reproducible on Beta Migration Build 3 with Huawei P9 Lite (Android 7).

@ebalazs-sv
Copy link
Author

This is reproducible on Beta Migration build 4.0.0-beta.2, 3/10 with Huawei P9 Lite (Android 7).

@ebalazs-sv
Copy link
Author

This is still reproducible on Beta Migration build 4, 3/24, with Huawei P9 Lite (Android 7).

@ebalazs-sv
Copy link
Author

The "Start Firefox" button is visible in split mode, since the issue #7978 is verified on Release migration build 4.0.0-beta.2 GV 76 4/8 with Motorola G6 (Android 8), Huawei P9 Lite (Android 7) and the entire migration screen page is scrollable.
I will also verify this on the next migration build.

@ebalazs-sv
Copy link
Author

ebalazs-sv commented Apr 27, 2020

In the issue #7978 (comment) it was decided that the "Start Firefox" button will remain fixed while the rest of the screen scrolls behind it.

This is verified as fixed and this issue is not reproducible anymore due to that.

Devices used: Huawei P9 Lite (Android 7), Nexus 5 (Android 6.0.1).

I will close this issue and move it to Done.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Migration
Projects
None yet
Development

No branches or pull requests

2 participants