Emergency shutoff button is clickable when it is disabled

[allan-silva]

Found while working on #2604 (maybe a good first bug)

When product/channel is not selected:

When updates is already disabled:

[mays4]

I am an outreach applicant, I don't see the first-bug issue available (all assigned or commented by applicants), so can I work on this issue?

[allan-silva]

Hey @gabrielBusta, can you assign this issue to @mays4 ?
It looks like a good-first-bug.

[MelakuAlehegn]

@gabrielBusta @bhearsum there has been no PR on this issue, can I work on it?

[MelakuAlehegn]

@allan-silva can you provide more context on which pages to look for, files to edit?

[bhearsum]

The fix will almost certainly be in https://github.com/mozilla-releng/balrog/blob/main/ui/src/views/Rules/ListRules/index.jsx#L137. Based on @allan-silva's earlier comment & screenshot it sounds like productChannelQueries may not be set when an emergency shutoff has been done. My suggestion would be to add some console.log messages to this file and then:

• Visit https://localhost:9000/rules?product=Firefox&channel=release
• Open the Developer Tools Console
• Reload the page, and make note of any log messages that show up
• Use "Disable updates" in the bottom right of the view to set the emergency shutoff
• Reload the page, and compare the log messages that show up this time

[MelakuAlehegn]

@bhearsum Thanks for your prompt response. Taking a look..

[AMUZY]

I tried to replicate the issue @bhearsum but there seems to be no issue with this. I followed the steps as well as @allan-silva's message and the page seems to be fine.
I had no errors in my debug tools when I disabled updates for a product (Firefox : Release) in my case, and then selected All Rules.
Maybe this has been fixed? Or I'm not replicating the issue correctly?
@MelakuAlehegn have you been able to replicate this issue?

[AMUZY]

Can't see any error that looks like the image @allan-silva shared

[allan-silva]

Hello everyone, try to reproduce in the following order:

1. Click on rules;
2. On rules page, select a product/channel (eg.: Firefox : Nightly);
3. Click on "pause button" to disable product/channel updates;
4. Optionally say the reason and click "Yes".

Now updates for product/channel are disabled.

5. repeate the steps 3 and 4 (notice the pause button is disabled, but is clickable)

[AMUZY]

Ooooh ! Let me do this

[MelakuAlehegn]

@allan-silva it looks like the button is clickable for disabled updates, as you explained. Confirming that the error exists.

When Clicked again

[AMUZY]

Hi @bhearsum @gabrielBusta this ISSUE has been solved HERE and is safe to be closed now I guess. Bless y'all

[bhearsum]

Thanks, we missed that!