-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APK /sign/file can output unaligned ZIPs #154
Labels
Comments
motivating bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1495540 |
Autograph should focus on signing, so we'll have clients run zipalign after signing (see also #149), deprecate the compress all and zip alignment with the goal of removing them eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of discussion from #148 (review) and our IRC channel.
The problem:
Possible solutions:
/sign/hash
provide gradle plugin for gpg and apk signing #149 to avoid the issue. This is also 1) the most forward facing (i.e. can add support for more signing algs), 2) avoids sending the whole APK over the wire, and 3) provides nicer tooling for our Android devsThe text was updated successfully, but these errors were encountered: