This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Tests shouldn't depend on the network #429

Closed

peterbe opened this issue Apr 26, 2018 · 0 comments

Contributor

peterbe commented Apr 26, 2018

The tests shouldn't have to depend on the network. It makes it unpredictable in CI.
Actual network fetches should be caught and mocked.

peterbe closed this as completed in

1532d15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.