Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Support "hardcoded" tiles #179

Closed
data-sync-user opened this issue Jun 23, 2021 · 7 comments
Closed

Support "hardcoded" tiles #179

data-sync-user opened this issue Jun 23, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jun 23, 2021

We need the ability to configure a Tile not served from upstream (adM).

We can specify this in the inclusion filter alongside other advertisers, maybe with an explicit flag there to denote it should be included regardless of whether we see it served from upstream.

From https://mozilla-hub.atlassian.net/browse/CONSVC-1108 (closed as dupe):

Outstanding questions include:

  • how should we weight these?
  • do these records contain similar enough cache criteria as existing partners?
  • are there additional reporting data we need to capture?

┆Issue is synchronized with this Jira Task
┆Epic: Allow additional partners for Contile

@data-sync-user data-sync-user added the enhancement New feature or request label Jun 23, 2021
@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

One example of an initial advertiser that would be "hardcoded" has the following properties:

  1. No click/impression urls, we simply serve a landing page
  2. The landing page may differ by region

Unfortunately our current AdmSettings json doesn't yet accommodate #2. Each AdmSetting is keyed by the advertiser name, so it wouldn't allow configuring multiple "tiles" of the same advertiser (with differing include_region/advertiser_url's).

@data-sync-user
Copy link
Collaborator Author

➤ JR Conlin commented:

There's a lot of things that AdmSettings doesn't support. It's absolutely a band-aid to a larger problem.
(e.g. for "hardcoded" we might want to only serve it n% of the time, or rotate it with i number of alternates, or...)

All that kinda says that we need to have a separate tile management system in addition to whatever we poll from adM.

@data-sync-user
Copy link
Collaborator Author

➤ Amy Tsay commented:

Filed in backlog as this is not an MVP for Fx90 delivery. Use case of overriding Contile with hardcoded tiles can be handled using the current Remote Settings implementation.

@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

One example of an initial advertiser that would be "hardcoded" has the following properties:

  1. No click/impression urls, we simply serve a landing page
  2. The landing page may differ by region

Unfortunately our current AdmSettings json doesn't yet accommodate #2. Each AdmSetting is keyed by the advertiser name, so it wouldn't allow configuring multiple "tiles" of the same advertiser (with differing include_region/advertiser_url's).

@data-sync-user
Copy link
Collaborator Author

➤ JR Conlin commented:

There's a lot of things that AdmSettings doesn't support. It's absolutely a band-aid to a larger problem.
(e.g. for "hardcoded" we might want to only serve it n% of the time, or rotate it with i number of alternates, or...)

All that kinda says that we need to have a separate tile management system in addition to whatever we poll from adM.

@data-sync-user
Copy link
Collaborator Author

➤ Amy Tsay commented:

Filed in backlog as this is not an MVP for Fx90 delivery. Use case of overriding Contile with hardcoded tiles can be handled using the current Remote Settings implementation.

@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

One example of an initial advertiser that would be "hardcoded" has the following properties:

  1. No click/impression urls, we simply serve a landing page
  2. The landing page may differ by region

Unfortunately our current AdmSettings json doesn't yet accommodate #2. Each AdmSetting is keyed by the advertiser name, so it wouldn't allow configuring multiple "tiles" of the same advertiser (with differing include_region/advertiser_url's).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant