Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Call to DELETE /keys/ uses not-fully-escaped vapid_key string #238

Open
thexeos opened this issue Jul 30, 2016 · 0 comments
Open

Call to DELETE /keys/ uses not-fully-escaped vapid_key string #238

thexeos opened this issue Jul 30, 2016 · 0 comments

Comments

@thexeos
Copy link

thexeos commented Jul 30, 2016

While testing the dev-dashboard, I used a Base64 (not URL friendly) public key to create a new application. When attempting to delete it, I got MessagesAPIError. It turned out the vapid_key was passed literally without encoding the forward slash.

The fix is to use quote(instance.vapid_key, safe='') to force all special characters to get URL encoded. #237

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant