Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment.yaml #760

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Update environment.yaml #760

merged 1 commit into from
Oct 8, 2020

Conversation

Prajwal7842
Copy link
Contributor

@vringar
This is related to the issue #759 . I ran repin.sh in a new branch. After running this, I tested the installation on my OS : Ubuntu 18.04 and also on gitpod. Now both seems to be working fine. Installation, now does not cause the error mentioned in the issue.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #760 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   40.10%   40.10%           
=======================================
  Files          29       29           
  Lines        3159     3159           
=======================================
  Hits         1267     1267           
  Misses       1892     1892           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a811af1...72fe004. Read the comment docs.

- geckodriver=0.27.0
- ipython=7.17.0
- flake8=3.8.4
- geckodriver=0.26.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@birdsarah do you have any idea why repining would have us switch to an older version of geckodriver?

@vringar vringar merged commit 6a8bd88 into openwpm:master Oct 8, 2020
Prajwal7842 added a commit to Prajwal7842/OpenWPM that referenced this pull request Oct 8, 2020
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants