Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up un-context-managed use of open #769

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

jyothisjagan
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #769 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   40.10%   40.06%   -0.04%     
==========================================
  Files          29       29              
  Lines        3159     3157       -2     
==========================================
- Hits         1267     1265       -2     
  Misses       1892     1892              
Impacted Files Coverage Δ
automation/TaskManager.py 77.60% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8bd88...8414c36. Read the comment docs.

@vringar vringar self-requested a review October 19, 2020 09:15
@vringar vringar merged commit 2f2f5f5 into openwpm:master Oct 19, 2020
Prajwal7842 added a commit to Prajwal7842/OpenWPM that referenced this pull request Oct 24, 2020
Clean up un-context-managed use of open (openwpm#769)
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants