Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional comments for #290 #293

Open
dzeber opened this issue Sep 22, 2022 · 0 comments
Open

Additional comments for #290 #293

dzeber opened this issue Sep 22, 2022 · 0 comments

Comments

@dzeber
Copy link
Contributor

dzeber commented Sep 22, 2022

@alberginia Is there a reason for keeping the Queue managed outside of the SyntheticDataStreamer? I feel like this is an implementation detail that should be encapsulated inside the streamer class. The queue could be a member variable of the SyntheticDataStreamer class, set up automatically when the streamer instance is created. Then SyntheticDataStreamer could have a get() method which gets an item from the queue. The streamer instance would then be passed to the ContinuousCopy class rather than the queue. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant