Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dispensary into the linter #869

Closed
tofumatt opened this issue Aug 3, 2016 · 4 comments · Fixed by #4006
Closed

Move dispensary into the linter #869

tofumatt opened this issue Aug 3, 2016 · 4 comments · Fixed by #4006

Comments

@tofumatt
Copy link
Contributor

tofumatt commented Aug 3, 2016

No one other than us seems to use https://github.com/mozilla/dispensary as a dependency. Updating it and the linter at the same time is a bit of a pain, so we should move dispensary into the linter to make updates easier.

@ioanarusiczki
Copy link

@willdurand In case this can be tested let me know.

@willdurand
Copy link
Member

@ioanarusiczki yeah, you can submit an extension with a known file from the list: https://github.com/mozilla/addons-linter/blob/master/src/dispensary/hashes.txt

@AlexandraMoga
Copy link

@willdurand I've tested with a few of the files mentioned in https://github.com/mozilla/addons-linter/blob/master/src/dispensary/hashes.txt and compared the validation results from -dev and prod. There were no differences as far as I could tell.

Here are some examples:

  • validation messages when certain .js libraries are identified in the archive(*)
    image
    *a note on angular - I've checked a few libraries and for all of them I've received the "Banned js library" error:
    image

  • validation messages for invalid syntax:
    image

@willdurand
Copy link
Member

@willdurand I've tested with a few of the files mentioned in master/src/dispensary/hashes.txt and compared the validation results from -dev and prod. There were no differences as far as I could tell.

No difference = good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants