Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Expose whether a version is soft or hard-blocked in the blocked API #15015

Open
2 tasks
diox opened this issue Sep 11, 2024 · 3 comments · May be fixed by mozilla/addons-server#22750
Open
2 tasks

[Task]: Expose whether a version is soft or hard-blocked in the blocked API #15015

diox opened this issue Sep 11, 2024 · 3 comments · May be fixed by mozilla/addons-server#22750
Assignees
Labels
repository:addons-server Issue relating to addons-server

Comments

@diox
Copy link
Member

diox commented Sep 11, 2024

Description

Depends on #15012

AMO API needs to expose for a specific version if it's soft-blocked or hard-blocked.

This could be done via adding a new property to https://mozilla.github.io/addons-server/topics/api/blocklist.html, or completely changing the existing versions property to be a list of objects, but if going that route note that v4 API needs to stay backwards-compatible.

The frontend will use this information in #15016.

Acceptance Criteria

Milestones/checkpoints

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.
  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@eviljeff
Copy link
Member

eviljeff commented Oct 9, 2024

If an add-on has all it's current (signed) versions blocked, and is disabled to prevent future versions, we define it as is_all_versions=True in the API, and use that to show "Versions blocked: all versions" on the blocked detail page; if not, we list the versions, like "Versions blocked: 1.2, 2.3, 456.789." and so on.

The question for @abyrne-moz / @wagnerand is: how should soft blocked versions affect this evaluation. If an add-on has all it's signed versions soft-blocked (or a mix of hard and soft), and is disabled, should it be is_all_versions=True? There's some dependency here on #15016 and if you want to differentiate the scenarios in the copy too.

@eviljeff
Copy link
Member

eviljeff commented Oct 9, 2024

but if going that route note that v4 API needs to stay backwards-compatible.

After writing and testing the shims - and for min_version/max_version too that are unused by frontend - ... I noticed that /blocklist is a v5 only API oh, v4 and v5, but not v3, nevermind

@eviljeff
Copy link
Member

how should soft blocked versions affect this evaluation. If an add-on has all it's signed versions soft-blocked (or a mix of hard and soft), and is disabled, should it be is_all_versions=True?

on slack @abyrne-moz said

I would say YES to this question. Because a user will come to the "soft block" version of the AMO blocked (The one with the soft block copy), and if they're all soft-blocked then we should mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants