[Bug]: review page version activity box can get cut

[diox]

What happened?

STR:

• Enable enable-activity-log-attachments switch
• Submit an unlisted add-on (single version)
• Get it auto-approved
• Soft-Block it
• Harden the block

Look closely at the version history in the review page: there is a visual artifact where the the text of the last activity appears to go over the border of the cell

(There are likely faster/easier ways to reproduce - but you probably need a single version, then enough single-line activities to be higher than the left-side column)

What did you expect to happen?

The text shouldn't go over the border like that

This is caused by enable-activity-log-attachments because when it's enabled, it adds another cell to each row of activity... but only those, the rest of the table only have 2 cells per row.

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[diox]

We should either move the attachment to the second column instead of its own column, or ensure there are 3 columns for every row.

[ioanarusiczki]

I've seen this now on -stage at version unblocked

later edit
on dev

[diox]

A variant I saw in production, with more history (I'm only including a partial screenshot since this is prod data):

[ioanarusiczki]

I've checked on dev that enable-activity-log-attachments is enabled.

I could reproduce it with:

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/634903

or with reviewer notes https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/634904

[chrstinalin]

It looks like there's some OS-related trickery here, as I'm unable to reproduce those bugs on my MacOS machine (tables render as expected), but does indeed occur on my Windows machine. @ioanarusiczki Could I confirm which OS you're using?

For context, on my MacOS machine --

[ioanarusiczki]

@chrstinalin yes, I was using Win11

[ioanarusiczki]

Yes, it looks good now on win too.