Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix or supress the ResourceWarning in the tests #6436

Closed
eviljeff opened this issue Feb 27, 2019 · 1 comment
Closed

fix or supress the ResourceWarning in the tests #6436

eviljeff opened this issue Feb 27, 2019 · 1 comment
Labels
repository:addons-server Issue relating to addons-server state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.

Comments

@eviljeff
Copy link
Member

Under python3 we get many (many!) warnings in the logs such as

.tox/devhub/lib/python3.6/site-packages/mock/mock.py:1986
/home/travis/build/mozilla/addons-server/.tox/devhub/lib/python3.6/site-packages/mock/mock.py:1986: ResourceWarning: unclosed <socket.socket fd=18, family=AddressFamily.AF_INET, type=2049, proto=0, laddr=('127.0.0.1', 39844), raddr=('127.0.0.1', 11211)>
setattr(_type, entry, MagicProxy(entry, self))

https://github.com/kennethreitz/requests/issues/3912 and https://github.com/kennethreitz/requests/issues/1882 discuss it. I skim read them and I'm not sure it's fixable (or worth the effort to fix something that only occurs in our tests) mobolic/facebook-sdk#364 has an example of how to suppress the warnings

@stale
Copy link

stale bot commented Sep 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Sep 24, 2019
@stale stale bot closed this as completed Oct 8, 2019
@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.
Projects
None yet
Development

No branches or pull requests

3 participants