Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firefox-ios SyncIntegrationTests to our smoketest suite #2921

Closed
rfk opened this issue Apr 8, 2020 · 3 comments
Closed

Add firefox-ios SyncIntegrationTests to our smoketest suite #2921

rfk opened this issue Apr 8, 2020 · 3 comments

Comments

@rfk
Copy link
Contributor

rfk commented Apr 8, 2020

The firefox-ios repository contains some basic "live" integration tests for sync-related functionality, which attempt to connect a firefox-ios and a Desktop device to the same account and confirm that a bookmark/password/whatever can successfully sync between them:

https://github.com/mozilla-mobile/firefox-ios/tree/master/SyncIntegrationTests

I think these would be a great addition to the smoke-test-firefox-ios.py script, but unfortunately I have not yet been able to get them running reliably on my machine. I'm out of time to debug this further in the current testing-related epic, but wanted to file this issue to revisit another time.

(I managed to get the tests running with a couple of tweaks captured in mozilla-mobile/firefox-ios#6389 but they don't pass for me).

┆Issue is synchronized with this Jira Task

@rfk
Copy link
Contributor Author

rfk commented Apr 9, 2020

To add a bit more status, I was able to get them running and attempting to sync a bookmark between the two devices, but the desktop-side test would fail saying it was unable to find the resulting bookmark. These are the logs generated by running pipenv run pytext -xs:

But I'm not sure how to debug further.

@isabelrios
Copy link
Contributor

I was able to get them running and attempting to sync a bookmark between the two devices, but the desktop-side test would fail saying it was unable to find the resulting bookmark. These are the logs generated by running pipenv run pytext -xs:

This may be due to this error mozilla-mobile/firefox-ios#6311
Once the bookmark is created on Mobile we force the sync to be sure it is synced, but due to that issue, the test finishes on Mobile side before the sync process has finished.
Could you try to run this the test that starts on Desktop and check on Mobile?
Comment all the tests except for this one to try: https://github.com/mozilla-mobile/firefox-ios/blob/master/SyncIntegrationTests/test_integration.py#L6
Hopefully that will work.. 🤞

@isabelrios
Copy link
Contributor

FYi, There is an "external" error affecting these tests: mozilla-mobile/firefox-ios#6400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants