Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendored libs warning about from collections import <Abstract> instead of collections.abc #518

Closed
aaronchall opened this issue Mar 2, 2020 · 1 comment · Fixed by #548

Comments

@aaronchall
Copy link

aaronchall commented Mar 2, 2020

Vendored libs warning about from collections import <Abstract> instead of collections.abc

This is an issue in both

  • bleach/bleach/_vendor/html5lib/_trie/_base.py
    from collections import Mapping
    should be
    from collections.abc import Mapping

and

  • bleach/bleach/_vendor/html5lib/treebuilders/dom.py
    from collections import MutableMapping
    should be
    from collections.abc import MutableMapping
=============================== warnings summary ===============================
/nix/store/2xz5xcz568v9vdasqf9p45w97znkm8pp-python3.8-bleach-3.1.0/lib/python3.8/site-packages/bleach/_vendor/html5lib/_trie/_base.py:3
  /nix/store/2xz5xcz568v9vdasqf9p45w97znkm8pp-python3.8-bleach-3.1.0/lib/python3.8/site-packages/bleach/_vendor/html5lib/_trie/_base.py:3: 
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, 
and in 3.9 it will stop working
    from collections import Mapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html

These are alluded to here as well: #425

@aaronchall
Copy link
Author

#521

@g-k g-k mentioned this issue Sep 15, 2020
@g-k g-k closed this as completed in #548 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant