Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: hardcoded dev dependency versions breaks mypy usage #679

Closed
q-wertz opened this issue Oct 20, 2022 · 5 comments
Closed

bug: hardcoded dev dependency versions breaks mypy usage #679

q-wertz opened this issue Oct 20, 2022 · 5 comments
Milestone

Comments

@q-wertz
Copy link

q-wertz commented Oct 20, 2022

Describe the bug

I'm having an indirect bleach dependency in my code. Due to the usage of poetry my mypy version is restricted to "mypy (==0.961)" by bleach. This mypy version is not compatible with positional-only parameters (see python/mypy#13627).

Thus I cannot use mypy anymore.

It would be nice if you could update your dev dependencies:

"mypy==0.961; implementation_name=='cpython'",

python and bleach versions (please complete the following information):

  • Python Version: 3.10.7
  • Bleach Version: 5.0.1

To Reproduce

Steps to reproduce the behavior:

Numpy uses these kind of parameters so it is sufficient to run mypy on a script that imports numpy:

  1. Create new file test.py
    import numpy
  2. Run mypy test.py

Expected behavior

mypy does what it should do

@q-wertz q-wertz added the untriaged Bug reports that haven't been triaged label Oct 20, 2022
@willkg
Copy link
Member

willkg commented Oct 20, 2022

I don't understand why this would be an issue. Are you installing the dev dependencies?

@q-wertz
Copy link
Author

q-wertz commented Oct 20, 2022

As far as I understand it poetry also tracks the dev dependencies from used libraries and groups them in the dev group to which also the packages that I need for developing are added. So when I install the dev dependencies the most restricted version of mypy is installed (which is the one from bleach in my case).

@willkg
Copy link
Member

willkg commented Oct 20, 2022

Huh. That sounds like an unhelpful behavior for Poetry. Unless you're doing development on Bleach, the tools for your application shouldn't be tracking Bleach dev dependencies.

I'll look at redoing how Bleach tracks dev dependencies.

@willkg willkg added this to the 5.0.2 (tentative) milestone Oct 20, 2022
@willkg willkg removed the untriaged Bug reports that haven't been triaged label Oct 20, 2022
@q-wertz
Copy link
Author

q-wertz commented Oct 26, 2022

I think it was an issue on my side. Sorry for the noise.

@q-wertz q-wertz closed this as completed Oct 26, 2022
@willkg
Copy link
Member

willkg commented Oct 26, 2022

Glad you figured something out! I will change how we manage dev dependencies in the next update soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants