Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run build fails on jshint running over localization files if run more than once #559

Closed
Pomax opened this issue Jul 11, 2016 · 7 comments
Labels

Comments

@Pomax
Copy link

Pomax commented Jul 11, 2016

It looks like the locale files that are pulled in during npm run build are dropped in a location that is covered by the jshint task, such that when you run npm run build a second time, the build process gets cut off over code style errors.

Running npm run unlocalize to remove the locale files prior to running npm run build fixes this, so a build might need to either scrub those files and refetch, or the jshint task will need to be told to ignore the place(s) where we drop locale files

(tested on windows 10)

@Pomax Pomax added the Bug label Jul 11, 2016
@gideonthomas
Copy link

I cannot reproduce this error on Mac. But on Windows, the following error is seen:

> Brackets@1.4.0-0 build ...\mozilla\brackets
> grunt build-browser

Running "jshint:src" (jshint) task
Linting src/nls/dsb/strings.js...ERROR
[L118:C75] W107: Script URL.
    "DETECTED_EXCLUSION_TITLE": "JavaScript: Problem datajoweje inference",
Linting src/nls/hsb/strings.js...ERROR
[L118:C75] W107: Script URL.
    "DETECTED_EXCLUSION_TITLE": "JavaScript: Problem datajoweje inferency",

Warning: Task "jshint:src" failed. Use --force to continue.

@kyasbal
Copy link

kyasbal commented Oct 1, 2016

I could reproduce this issue too. Is there any plan to fix this issue?

@Pomax
Copy link
Author

Pomax commented Oct 1, 2016

probably the best solution would be to switch to a current ESLint vesion, having joined forces with JSCS to be a combined linter and formatter, with numerous fixes that improve on the old jshint parsing and reporting.

@gideonthomas
Copy link

I'll just update brackets with what's upstream, they use eslint now.

@humphd
Copy link

humphd commented Feb 17, 2017

Is this fixed now that we have switched over to eslint?

@gideonthomas
Copy link

@Pomax are you able to confirm this? ^

@Pomax
Copy link
Author

Pomax commented Feb 21, 2017

pretty sure it's fixed because I had to run the brackets build to make things work last week and did not run into this. sooooo closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants