-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm run build
fails on jshint running over localization files if run more than once
#559
Comments
I cannot reproduce this error on Mac. But on Windows, the following error is seen:
|
I could reproduce this issue too. Is there any plan to fix this issue? |
probably the best solution would be to switch to a current ESLint vesion, having joined forces with JSCS to be a combined linter and formatter, with numerous fixes that improve on the old jshint parsing and reporting. |
I'll just update brackets with what's upstream, they use eslint now. |
Is this fixed now that we have switched over to eslint? |
@Pomax are you able to confirm this? ^ |
pretty sure it's fixed because I had to run the brackets build to make things work last week and did not run into this. sooooo closed! |
It looks like the locale files that are pulled in during
npm run build
are dropped in a location that is covered by the jshint task, such that when you runnpm run build
a second time, the build process gets cut off over code style errors.Running
npm run unlocalize
to remove the locale files prior to runningnpm run build
fixes this, so a build might need to either scrub those files and refetch, or the jshint task will need to be told to ignore the place(s) where we drop locale files(tested on windows 10)
The text was updated successfully, but these errors were encountered: