-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with webpack+watch to make working on src/bramble/client less painful #597
Comments
We can try doing a watch and see if it takes too long |
Maybe comments on the client files telling developers to run the build or a read me file? |
A more technical fix, since people don't read docs, and even if they do, it's not always obvious when to do this. There are only a few instances where this file needs to get rebuilt, so it's easy to get it wrong. One thing we could do is move to using webpack instead of requirejs to build things, and then have it watch for changes that need to be rebuilt. Webpack is module agnostic, and is fine with doing AMD-style modules. There's actually a bit of movement on this front upstream, see https://github.com/adobe/brackets/search?utf8=%E2%9C%93&q=webpack&type=, and also adobe#12006 (comment). The requirejs build for the Bramble API is actually pretty small, and we might be able to migrate just that over to webpack as a first experiment, and then have it watch for changes to the files in order to rebuild on demand. I'll morph this bug into that. cc @Pomax, who I think knows quite a bit about webpack. |
Switching over from requirejs to webpack is not trivial - I'd actually advocate using
So when you run The real problem with watching in this specific case is that |
I watched one of my students struggle for days with code changes in
src/bramble/client/main.js
. The reason is that it requires you to runnpm run build
to create thedist/bramble.js
client API that Thimble uses.I'm not sure what the best way to deal with this would be, from watching that dir and auto-creating it, or somehow not requiring a build step, or something else. But it's pretty crappy right now.
Here is the bit of the
Gruntfile
that is responsible for it:https://github.com/mozilla/brackets/blob/master/Gruntfile.js#L276-L292
The text was updated successfully, but these errors were encountered: