Skip to content

Commit a5a9c0f

Browse files
benjaminmahbenjaminmah
committed
Added 2 tests for FilePaths feature
1 parent 5c31f6c commit a5a9c0f

File tree

2 files changed

+195
-0
lines changed

2 files changed

+195
-0
lines changed

‎tests/fixtures/bug_features/file_paths.json‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"summary": "<nsFrame.cpp> cleanup",
3+
"comments": [
4+
{
5+
"text": "Fix for\n{{ <http://tinderbox.mozilla.org/SeaMonkey/warn1082809200.7591.html>\nanthonyd (2 warnings)\n1.\tlayout/html/base/src/nsFrame.cpp:3879 (See build log excerpt)\n\t`nsIFrame*thisBlock' might be used uninitialized in this function\n2.\tlayout/html/base/src/nsFrame.cpp:3908 (See build log excerpt)\n\t`nsIFrame*thisBlock' might be used uninitialized in this function\n}} (NB: lines should be lines - 2, due to checkin \"in progress\")\nwill be included."
6+
}
7+
]
8+
}
9+
{
10+
"summary": "Spidermonkey regression causes treehydra trunk to fail 6 tests",
11+
"comments": [
12+
{
13+
"text": "Today I'm trying to get callgraph stuff hooked into dxr, and I'm unable to get a working treehydra. I've updated tried updating just dehydra, then I updated gcc w/plugins using the new stuff in the patch queue, and it doesn't matter. Running make check_treehydra fails like this:\n\nTest Failure: \n Test command: /var/www/html/dxr/tools/gcc-dehydra/installed/bin/../libexec/gcc/x86_64-unknown-linux-gnu/4.3.0/cc1plus -quiet -fplugin=../gcc_treehydra.so -o /dev/null -fplugin-arg=test_locks_bad3.js locks_bad3.cc\n Failure msg: Expected 'locks_bad3.cc:10: error: precondition not met' in error output; not found. stderr:../libs/treehydra.js:12: JS Exception: No case_val in this lazy object\n:0: #0: Error(\"No case_val in this lazy object\")\n../libs/treehydra.js:12: #1: unhandledLazyProperty(\"case_val\")\n../libs/unstable/esp.js:481: #2: ()\n./esp_lock.js:41: #3: process_tree([object GCCNode])\n\nTest Failure: \n Test command: /var/www/html/dxr/tools/gcc-dehydra/installed/bin/../libexec/gcc/x86_64-unknown-linux-gnu/4.3.0/cc1plus -quiet -fplugin=../gcc_treehydra.so -o /dev/null -fplugin-arg=test_locks_good.js locks_good.cc\n Failure msg: Expected no error output, got error output :../libs/treehydra.js:12: JS Exception: No case_val in this lazy object\n:0: #0: Error(\"No case_val in this lazy object\")\n../libs/treehydra.js:12: #1: unhandledLazyProperty(\"case_val\")\n../libs/unstable/esp.js:481: #2: ()\n./esp_lock.js:41: #3: process_tree([object GCCNode])\n\nTest Failure: \n Test command: /var/www/html/dxr/tools/gcc-dehydra/installed/bin/../libexec/gcc/x86_64-unknown-linux-gnu/4.3.0/cc1plus -quiet -fplugin=../gcc_treehydra.so -o /dev/null -fplugin-arg=test_locks_good2.js locks_good2.cc\n Failure msg: Expected no error output, got error output :../libs/treehydra.js:12: JS Exception: No case_val in this lazy object\n:0: #0: Error(\"No case_val in this lazy object\")\n../libs/treehydra.js:12: #1: unhandledLazyProperty(\"case_val\")\n../libs/unstable/esp.js:481: #2: ()\n./esp_lock.js:41: #3: process_tree([object GCCNode])\n\nTest Failure: \n Test command: /var/www/html/dxr/tools/gcc-dehydra/installed/bin/../libexec/gcc/x86_64-unknown-linux-gnu/4.3.0/cc1plus -quiet -fplugin=../gcc_treehydra.so -o /dev/null -fplugin-arg=test_locks_bad4.js locks_bad4.cc\n Failure msg: Expected 'locks_bad4.cc:13: error: precondition not met' in error output; not found. stderr:../libs/treehydra.js:12: JS Exception: No case_val in this lazy object\n:0: #0: Error(\"No case_val in this lazy object\")\n../libs/treehydra.js:12: #1: unhandledLazyProperty(\"case_val\")\n../libs/unstable/esp.js:481: #2: ()\n./esp_lock.js:41: #3: process_tree([object GCCNode])\n\nTest Failure: \n Test command: /var/www/html/dxr/tools/gcc-dehydra/installed/bin/../libexec/gcc/x86_64-unknown-linux-gnu/4.3.0/cc1plus -quiet -fplugin=../gcc_treehydra.so -o /dev/null -fplugin-arg=test_locks_bad2.js locks_bad2.cc\n Failure msg: Expected 'locks_bad2.cc:12: error: precondition not met' in error output; not found. stderr:../libs/treehydra.js:12: JS Exception: No case_val in this lazy object\n:0: #0: Error(\"No case_val in this lazy object\")\n../libs/treehydra.js:12: #1: unhandledLazyProperty(\"case_val\")\n../libs/unstable/esp.js:481: #2: ()\n./esp_lock.js:41: #3: process_tree([object GCCNode])\n\nTest Failure: \n Test command: /var/www/html/dxr/tools/gcc-dehydra/installed/bin/../libexec/gcc/x86_64-unknown-linux-gnu/4.3.0/cc1plus -quiet -fplugin=../gcc_treehydra.so -o /dev/null -fplugin-arg=test_locks_bad1.js locks_bad1.cc\n Failure msg: Expected 'locks_bad1.cc:11: error: precondition not met' in error output; not found. stderr:../libs/treehydra.js:12: JS Exception: No case_val in this lazy object\n:0: #0: Error(\"No case_val in this lazy object\")\n../libs/treehydra.js:12: #1: unhandledLazyProperty(\"case_val\")\n../libs/unstable/esp.js:481: #2: ()\n./esp_lock.js:41: #3: process_tree([object GCCNode])\n\n\nUnit Test Suite Summary:\n 32 passed\n 6 failed\n 0 error(s)\nmake[1]: *** [check_treehydra] Error 1\nmake[1]: Leaving directory `/var/www/html/dxr/tools/gcc-dehydra/dehydra/test'\nmake: *** [check] Error 2"
14+
}
15+
]
16+
}

‎tests/test_bug_features.py‎

Lines changed: 179 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
CommentLength,
1818
Component,
1919
DeltaNightlyRequestMerge,
20+
FilePaths,
2021
HasCrashSignature,
2122
HasCVEInAlias,
2223
HasGithubURL,
@@ -187,3 +188,181 @@ def test_BugTypes(read) -> None:
187188
BugTypes,
188189
[["performance"], ["memory"], ["power"], ["security"], ["crash"]],
189190
)
191+
192+
193+
def test_FilePaths(read):
194+
read(
195+
"file_paths.json",
196+
FilePaths,
197+
[
198+
[
199+
"nsFrame.cpp",
200+
"layout",
201+
"html",
202+
"base",
203+
"src",
204+
"nsFrame.cpp",
205+
"layout/html/base/src/nsFrame.cpp",
206+
"html/base/src/nsFrame.cpp",
207+
"base/src/nsFrame.cpp",
208+
"src/nsFrame.cpp",
209+
"nsFrame.cpp",
210+
"layout",
211+
"html",
212+
"base",
213+
"src",
214+
"nsFrame.cpp",
215+
"layout/html/base/src/nsFrame.cpp",
216+
"html/base/src/nsFrame.cpp",
217+
"base/src/nsFrame.cpp",
218+
"src/nsFrame.cpp",
219+
"nsFrame.cpp",
220+
],
221+
[
222+
"gcc_treehydra.so",
223+
"/gcc_treehydra.so",
224+
"gcc_treehydra.so",
225+
"test_locks_bad3.js",
226+
"libs",
227+
"treehydra.js",
228+
"/libs/treehydra.js",
229+
"libs/treehydra.js",
230+
"treehydra.js",
231+
"libs",
232+
"treehydra.js",
233+
"/libs/treehydra.js",
234+
"libs/treehydra.js",
235+
"treehydra.js",
236+
"libs",
237+
"unstable",
238+
"esp.js",
239+
"/libs/unstable/esp.js",
240+
"libs/unstable/esp.js",
241+
"unstable/esp.js",
242+
"esp.js",
243+
"esp_lock.js",
244+
"/esp_lock.js",
245+
"esp_lock.js",
246+
"gcc_treehydra.so",
247+
"/gcc_treehydra.so",
248+
"gcc_treehydra.so",
249+
"test_locks_good.js",
250+
"libs",
251+
"treehydra.js",
252+
"/libs/treehydra.js",
253+
"libs/treehydra.js",
254+
"treehydra.js",
255+
"libs",
256+
"treehydra.js",
257+
"/libs/treehydra.js",
258+
"libs/treehydra.js",
259+
"treehydra.js",
260+
"libs",
261+
"unstable",
262+
"esp.js",
263+
"/libs/unstable/esp.js",
264+
"libs/unstable/esp.js",
265+
"unstable/esp.js",
266+
"esp.js",
267+
"esp_lock.js",
268+
"/esp_lock.js",
269+
"esp_lock.js",
270+
"gcc_treehydra.so",
271+
"/gcc_treehydra.so",
272+
"gcc_treehydra.so",
273+
"test_locks_good2.js",
274+
"libs",
275+
"treehydra.js",
276+
"/libs/treehydra.js",
277+
"libs/treehydra.js",
278+
"treehydra.js",
279+
"libs",
280+
"treehydra.js",
281+
"/libs/treehydra.js",
282+
"libs/treehydra.js",
283+
"treehydra.js",
284+
"libs",
285+
"unstable",
286+
"esp.js",
287+
"/libs/unstable/esp.js",
288+
"libs/unstable/esp.js",
289+
"unstable/esp.js",
290+
"esp.js",
291+
"esp_lock.js",
292+
"/esp_lock.js",
293+
"esp_lock.js",
294+
"gcc_treehydra.so",
295+
"/gcc_treehydra.so",
296+
"gcc_treehydra.so",
297+
"test_locks_bad4.js",
298+
"libs",
299+
"treehydra.js",
300+
"/libs/treehydra.js",
301+
"libs/treehydra.js",
302+
"treehydra.js",
303+
"libs",
304+
"treehydra.js",
305+
"/libs/treehydra.js",
306+
"libs/treehydra.js",
307+
"treehydra.js",
308+
"libs",
309+
"unstable",
310+
"esp.js",
311+
"/libs/unstable/esp.js",
312+
"libs/unstable/esp.js",
313+
"unstable/esp.js",
314+
"esp.js",
315+
"esp_lock.js",
316+
"/esp_lock.js",
317+
"esp_lock.js",
318+
"gcc_treehydra.so",
319+
"/gcc_treehydra.so",
320+
"gcc_treehydra.so",
321+
"test_locks_bad2.js",
322+
"libs",
323+
"treehydra.js",
324+
"/libs/treehydra.js",
325+
"libs/treehydra.js",
326+
"treehydra.js",
327+
"libs",
328+
"treehydra.js",
329+
"/libs/treehydra.js",
330+
"libs/treehydra.js",
331+
"treehydra.js",
332+
"libs",
333+
"unstable",
334+
"esp.js",
335+
"/libs/unstable/esp.js",
336+
"libs/unstable/esp.js",
337+
"unstable/esp.js",
338+
"esp.js",
339+
"esp_lock.js",
340+
"/esp_lock.js",
341+
"esp_lock.js",
342+
"gcc_treehydra.so",
343+
"/gcc_treehydra.so",
344+
"gcc_treehydra.so",
345+
"test_locks_bad1.js",
346+
"libs",
347+
"treehydra.js",
348+
"/libs/treehydra.js",
349+
"libs/treehydra.js",
350+
"treehydra.js",
351+
"libs",
352+
"treehydra.js",
353+
"/libs/treehydra.js",
354+
"libs/treehydra.js",
355+
"treehydra.js",
356+
"libs",
357+
"unstable",
358+
"esp.js",
359+
"/libs/unstable/esp.js",
360+
"libs/unstable/esp.js",
361+
"unstable/esp.js",
362+
"esp.js",
363+
"esp_lock.js",
364+
"/esp_lock.js",
365+
"esp_lock.js",
366+
],
367+
],
368+
)

0 commit comments

Comments
 (0)