Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the unaudited table to the "exemptions" table #228

Closed
bholley opened this issue Jun 24, 2022 · 1 comment · Fixed by #237
Closed

Rename the unaudited table to the "exemptions" table #228

bholley opened this issue Jun 24, 2022 · 1 comment · Fixed by #237
Assignees
Labels
p1 do now

Comments

@bholley
Copy link
Collaborator

bholley commented Jun 24, 2022

I've concluded that the current name is confusing, and that it's more self-explanatory to talk about "audits, imports, and exemptions".

Given that we haven't done a proper release yet and things are still somewhat use-at-your-own-risk, I don't think an automatic migration is essential. But @Gankra thinks it might be easy to do with a serde annotation — if so we might as well do that.

@bholley bholley added the p1 do now label Jun 24, 2022
@Gankra
Copy link
Contributor

Gankra commented Jun 27, 2022

This should in principle be trivially accomplished by https://serde.rs/field-attrs.html#alias but I would like to avoid poking this while #225 and #230 are in flight and touching so much code.

@Gankra Gankra self-assigned this Jun 27, 2022
@Gankra Gankra mentioned this issue Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 do now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants