Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: css affect to website which has css contain .is-hidden class #898

Open
ghost opened this issue Nov 11, 2022 · 10 comments
Open

bug: css affect to website which has css contain .is-hidden class #898

ghost opened this issue Nov 11, 2022 · 10 comments

Comments

@ghost
Copy link

ghost commented Nov 11, 2022

https://github.com/mozilla/contain-facebook/blob/a7a39f46486b8455d1de24bfba39e65ec95aa06c/src/content_script.css#L352ass

image

I have access a website which contains .is-hidden class inside. When I turn on facebook container extension, it hides this class. I've seen patch to fix this (in file content_scipt.css). But it doesn't seem to work or maybe your app hasn't deployed yet . Please review it, thank you at all.

@krystian3w
Copy link

krystian3w commented Nov 21, 2022

maybe your app hasn't deployed yet

Yes, commit a7a39f4 don't arrived to public signed xpi (made on 5 Nov and merged ~3 days later, but xpi is from 31 Oct).

#886 (comment)

It will be a part of our next release!

It remains to wait patiently.

@robmadole
Copy link

This also is affecting fontawesome.com/search. We're putting a workaround in place to fix.

@ghost
Copy link
Author

ghost commented Nov 23, 2022

@krystian3w @robmadole
thank you! :D

@abatkin
Copy link

abatkin commented Dec 2, 2022

In case anyone comes searching. Stumptown Coffee Roasters checkout page is broken until this is released.

@TimmiX88
Copy link

TimmiX88 commented Dec 15, 2022

This still hasn't been fixed, i still see the content_script.css being loaded into websites and it's styling affecting the website. Especially the .is-hidden class makes quite a few websites unusable. Please fix/rollout asap.

Edit: i see in the commits that a fix has been committed on november 5th, which sort of 'scopes' the .is-hidden class. However, the plugin says i am on the latest version (2.3.9, released on november 3rd). So seems that the rollout has stopped?

@TimmiX88
Copy link

TimmiX88 commented Jan 12, 2023

This still hasn't rolled out. @maxxcrawford can you (or anyone at the team) please release this asap? Getting complains from clients that websites aren't working in Firefox and we shouldn't need to make changes to our websites if you just roll out the fix that has been commited months ago.

@JenniferKiesel
Copy link

I also experience this behaviour on the online banking website of "Sparkasse".

@krystian3w
Copy link

Someone has some issues more important than spoiling hundreds of pages.

@BradyThe
Copy link

BradyThe commented May 3, 2023

That certainly explains the issue I had with a particular website.

For now I am using Stylus in combination with this code to dirty-fix this problem:

.is-hidden {
    display: inherit !important;
}

#fbc-email.is-hidden, #fbc-login.is-hidden {
    display: none;
}

@krystian3w
Copy link

krystian3w commented Feb 13, 2024

Possible remove these dirty hacks if we try update to 2.3.10 or 2.3.11 from July 2023.

https://addons.mozilla.org/addon/facebook-container/versions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants