New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NimbusReviewSerializer tests are repetitive #11142

Open

brennie opened this issue Aug 2, 2024 · 0 comments

Member

brennie commented Aug 2, 2024 •

edited by data-sync-user

Loading

Almost every NimbusReviewSerializer test includes the following snippet:

        serializer = NimbusReviewSerializer(
            experiment,
            data=NimbusReviewSerializer(experiment, context={"user": self.user}).data,
            context={"user": self.user},
        )

We should add a helper to the testcase for this, which would remove ~500 lines and make tests easier to write.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment