Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Translations with all caps text sometimes fail #486

Closed
cadeyrn opened this issue Aug 7, 2022 · 2 comments
Closed

Translations with all caps text sometimes fail #486

cadeyrn opened this issue Aug 7, 2022 · 2 comments
Labels
bug Something isn't working engine-related

Comments

@cadeyrn
Copy link

cadeyrn commented Aug 7, 2022

Describe the bug

Firefox Translations has sometimes issues with translating if all letters are uppercase, as not unusual for headlines on some websites.

To Reproduce

  1. Set your content language to German
  2. Open https://edition.cnn.com/2022/08/05/uk/royal-news-newsletter-08-05-22-scli-gbr-cmd-intl/index.html
  3. Look at the all caps headlines "DID YOU KNOW?", "WHAT ELSE IS HAPPENING?" and "PHOTO OF THE WEEK"
  4. Press the translate button
  5. Reload the website
  6. Use the developer tools to change the above headlines to "Did you know?", "What else is happening?" and "Photo of the week"
  7. Repeat step 4

Expected behavior

The headlines are translated and the result is the same after step 4 and after step 7.

Actual behavior

Translations after step 4:

DID SIE WISSEN?
WAS ELSE IST HAPPENING?
FOTO DER WOCHE

(The first two are a mix of English and German words, the last translation is correct)

Translations after step 7:

Wussten Sie?
Was ist noch los?
Foto der Woche

(These are all correct translations)

Desktop (please complete the following information as possible):

Using fallback gemm implementation
Wasm Runtime initialized Successfully (preRun -> onRuntimeInitialized) in 0.004 secs
Creating Translation Service with config: {"cacheSize":0}
Translation Service created successfully
Constructing translation model ende
Translation Model config:
beam-size: 1
normalize: 1.0
word-penalty: 0
max-length-break: 128
mini-batch-words: 1024
workspace: 128
max-length-factor: 2.0
skip-cost: true
cpu-threads: 0
quiet: true
quiet-translation: true
gemm-precision: int8shiftAlphaAll
alignment: soft
Aligned memory sizes: Model:17140835, Shortlist:3943644, Vocab: 784269
Model 'ende' successfully constructed. Time taken: 0.108 secs
loadLanguageModel function complete

System architecture and extension information can be found as follows:
Go to about:telemetry#environment-data in browser and share "architecture" field under "build" category and "cpu.extensions" field under "system" category

architecture aarch64
cpu.extensions [hasNEON]

@andrenatal andrenatal added bug Something isn't working engine-related and removed needs triage labels Aug 9, 2022
@kpu
Copy link
Contributor

kpu commented Aug 15, 2022

We need to add random capitalization to the training pipeline. https://github.com/browsermt/students .

@marco-c
Copy link
Contributor

marco-c commented Jul 11, 2023

This is tracked in mozilla/translations#73.

@marco-c marco-c closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working engine-related
Projects
None yet
Development

No branches or pull requests

4 participants