Removing PeoplePage usage #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youriwims
requested review from
Pomax and
mmmavis
and removed request for
cadecairos
Pomax
previously requested changes
Mar 29, 2019
youriwims
changed the title
Pomax
previously requested changes
Apr 1, 2019
There was a problem hiding this comment.
This crashes for me on install, so let's do this: leave the PeoplePage model (you already updated the PR for that, so that's good), and also leave the translation binding in translation.py. This will leave an orphaned class and translation binding, so move the translation binding all the way to the end of the file, with a big old comment above it going "The following bindings are obsolete and require cleanup" or something to that effect.
Pomax
reviewed
Apr 1, 2019
Pomax
reviewed
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2898
Related PRs/issues #2686
The
PeoplePageclass will be removed separately in a separate PR.