Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown not supported #5921

Closed
ghost opened this issue Jul 13, 2020 · 5 comments
Closed

Graceful shutdown not supported #5921

ghost opened this issue Jul 13, 2020 · 5 comments
Labels
Orphaned Temporary label for transitioning to jira cloud

Comments

@ghost
Copy link

ghost commented Jul 13, 2020

Description

In case of deployments that need to support zero-downtime, the support of graceful shutdown methods is essential, so that in-process requests can finish processing while new requests are being rejected.

Major runtime environments have settled for using SIGTERM as the default signal for a graceful shutdown:

Although pm2 uses SIGINT by default, that also does not seem to be supported by many services.

Steps to reproduce

  1. start a Docker container or the intended local server process of an affected service
  2. send signal TERM to the process

Expected result

Server process shuts down gracefully with with exit code 0.

Actual result

Nothing happens. Server process keeps running.

Environment

not applicable

┆Issue is synchronized with this Jira Task
┆Issue Number: FXA-2273

@ghost
Copy link
Author

ghost commented Jul 14, 2020

At least the following services currently do not support SIGTERM:

@ghost ghost mentioned this issue Jul 14, 2020
3 tasks
@jodyheavener
Copy link
Contributor

Looks like this closed in #5938

@ghost
Copy link
Author

ghost commented Jul 14, 2020

@jodyheavener
Actually, at least the email-service still doesn't support this, but that seems to be a longer story with Rocket:

Also, I didn't check all services, e.g. admin/support/payment. But for those, separate PR's would be better than to keep issues open for too long.

@jodyheavener
Copy link
Contributor

Ah, ok noted. Thanks for the heads up.

@jodyheavener jodyheavener reopened this Jul 14, 2020
@ghost ghost mentioned this issue Jul 16, 2020
3 tasks
@ghost
Copy link
Author

ghost commented Jul 18, 2020

Finally looked through all services and I think #5961 is now ready for review.

@dannycoates dannycoates added the Orphaned Temporary label for transitioning to jira cloud label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Orphaned Temporary label for transitioning to jira cloud
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants