Click on link with block child silently fails #1007

elliterate · 2017-10-06T21:16:32Z

Given a link with a block-level child (i.e., display: block), clicking on it will silently fail. No JavaScript or navigation is triggered. (Clicking on the child, however, will work.)

System

Version: 0.19.0
Platform: macOS 10.12.6
Firefox: 56.0; 57.0b6; 58.0a1
Selenium: py/3.6.0

Testcase

`test_click_link.py`

import inspect
import os.path
from unittest import TestCase, main

from selenium import webdriver
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities


_DIR = os.path.dirname(os.path.abspath(inspect.getfile(inspect.currentframe())))


class TestClickLink(TestCase):
    @classmethod
    def setUpClass(cls):
        capabilities = DesiredCapabilities.FIREFOX.copy()
        capabilities["marionette"] = True
        capabilities["moz:firefoxOptions"] = {"log": {"level": "trace"}}
        cls.browser = webdriver.Firefox(capabilities=capabilities)

    def setUp(self):
        self.browser.get("file://{}".format(os.path.join(_DIR, "index.html")))
        self.result = self.browser.find_element_by_id("result")

    def tearDown(self):
        self.browser.get("about:blank")

    @classmethod
    def tearDownClass(cls):
        cls.browser.quit()

    def test_click_link_without_child(self):
        link = self.browser.find_element_by_link_text("No Child")
        link.click()
        self.assertEqual(self.result.text, "Link was clicked.")

    def test_click_link_with_block_child(self):
        link = self.browser.find_element_by_link_text("Block Child")
        link.click()
        self.assertEqual(self.result.text, "Link was clicked.")

    def test_click_link_with_inline_child(self):
        link = self.browser.find_element_by_link_text("Inline Child")
        link.click()
        self.assertEqual(self.result.text, "Link was clicked.")

if __name__ == "__main__":
    main()

`index.html`

<html>
  <head>
    <script type="text/javascript">
      function handleClick(e) {
        e.preventDefault();
        document.querySelector("#result").innerText = "Link was clicked.";
      }
    </script>
  </head>

  <body>
    <div id="result"></div>
    <a href="#" onclick="handleClick(event)">No Child</a>
    <a href="#" onclick="handleClick(event)"><div>Block Child</div></a>
    <a href="#" onclick="handleClick(event)"><span>Inline Child</span></a>
  </body>
</html>

Stacktrace

$ python test_click_link.py
F..
======================================================================
FAIL: test_click_link_with_block_child (__main__.TestClickLink)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_click_link.py", line 39, in test_click_link_with_block_child
    self.assertEqual(self.result.text, "Link was clicked.")
AssertionError: '' != 'Link was clicked.'
+ Link was clicked.

----------------------------------------------------------------------
Ran 3 tests in 4.758s

FAILED (failures=1)

Trace-level log

geckodriver.log.txt

The text was updated successfully, but these errors were encountered:

elliterate · 2017-10-06T21:17:08Z

This may be related to #322.

whimboo · 2017-10-10T10:25:13Z

Thank you for the detailed report. I had a look at it, and indeed is a dupe of issue #322. It's also covered by bug 1374283 for Marionette.

elliterate · 2018-01-09T14:31:28Z

@whimboo #322 was just closed because it doesn't have "a concrete description of the problem or a trace log [you] can use to debug it." Can this one be re-opened, then? While this test passes in Firefox 57.0.4 (and geckodriver 0.19.1), it now fails loudly in 58.0b14 and 59.0a1 with the following:

$ python test_click_link.py
E..
======================================================================
ERROR: test_click_link_with_block_child (__main__.TestClickLink)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_click_link.py", line 38, in test_click_link_with_block_child
    link.click()
  File "/Users/ian/.pyenv/versions/2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py", line 78, in click
    self._execute(Command.CLICK_ELEMENT)
  File "/Users/ian/.pyenv/versions/2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py", line 499, in _execute
    return self._parent.execute(command, params)
  File "/Users/ian/.pyenv/versions/2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 297, in execute
    self.error_handler.check_response(response)
  File "/Users/ian/.pyenv/versions/2.7.9/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 194, in check_response
    raise exception_class(message, screen, stacktrace)
ElementNotInteractableException: Message: Element <a href="#"> could not be scrolled into view


----------------------------------------------------------------------
Ran 3 tests in 6.705s

FAILED (errors=1)

Trace-level log

geckodriver.log.2.txt

andreastt · 2018-01-09T14:37:39Z

Sounds like a fallout from the changes to make Element Click conform to the WebDriver standard, but this needs more investigation.

whimboo · 2018-01-10T07:59:39Z

The failure here happens for the following <a> node:

<a href="#" onclick="handleClick(event)"><div>Block Child</div></a>

So the <div> is completely overlaying the link here. This should be https://bugzilla.mozilla.org/show_bug.cgi?id=1374283.

whimboo closed this as completed Oct 10, 2017

elliterate mentioned this issue Jan 9, 2018

.click broken for Selenium 3 #322

Closed

andreastt reopened this Jan 9, 2018

andreastt added the marionette label Jan 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Click on link with block child silently fails #1007

Click on link with block child silently fails #1007

elliterate commented Oct 6, 2017

elliterate commented Oct 6, 2017

whimboo commented Oct 10, 2017

elliterate commented Jan 9, 2018

andreastt commented Jan 9, 2018

whimboo commented Jan 10, 2018 •

edited

Loading

Click on link with block child silently fails #1007

Click on link with block child silently fails #1007

Comments

elliterate commented Oct 6, 2017

System

Testcase

test_click_link.py

index.html

Stacktrace

Trace-level log

elliterate commented Oct 6, 2017

whimboo commented Oct 10, 2017

elliterate commented Jan 9, 2018

Trace-level log

andreastt commented Jan 9, 2018

whimboo commented Jan 10, 2018 • edited Loading

`test_click_link.py`

`index.html`

whimboo commented Jan 10, 2018 •

edited

Loading