Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to "All" ping types if GLAM doesn't know a ping type #1026

Closed
robhudson opened this issue Nov 12, 2020 · 0 comments
Closed

Default to "All" ping types if GLAM doesn't know a ping type #1026

robhudson opened this issue Nov 12, 2020 · 0 comments

Comments

@robhudson
Copy link
Member

Currently it attempts to pick a ping_type from the send_in_pings list, but there are some metrics for which GLAM isn't updated to recognize their ping type. In this case, default to "All" since we aggregate across all ping types. Over time we should update the ping types list to include all we know about.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robhudson