Microphone feedback #1536
Merged
Microphone feedback #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a/hubs into feature/glowing-mic Note: I regenerated spritesheets during merge
… into feature/glowing-mic
johnshaughnessy
commented
Jul 16, 2019
johnshaughnessy
commented
Jul 16, 2019
johnshaughnessy
commented
Jul 16, 2019
johnshaughnessy
commented
Jul 16, 2019
| @@ -595,6 +595,9 @@ class UIRoot extends Component { | |||
| if (micDeviceId) { | |||
| this.props.store.update({ settings: { lastUsedMicDeviceId: micDeviceId } }); | |||
| } | |||
| const mediaStreamForMicAnalysis = new MediaStream(); | |||
| mediaStreamForMicAnalysis.addTrack(this.state.audioTrack.clone()); | |||
| this.props.scene.emit("local-media-stream-created", { mediaStream: mediaStreamForMicAnalysis }); | |||
There was a problem hiding this comment.
I didn't think of a good way to "future proof" accidental mis-use of this mediaStream. When toggling your microphone, the janus adapter makes sure to disable the audio streams it knows about, so that's good. In general no one should be piping audio from this mediaStream into anything that is sent over the networked or saved to a file (like videos from the camera tool).
johnshaughnessy
force-pushed
the
feature/glowing-mic
branch
from
215abb9 to
ebe6c24
Compare
brianpeiris
added
whats new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The microphone icon now indicates volume level while speaking, even while muted.
These changes add a visual effect to the mic icons that reacts proportionally to the volume coming in from the user's microphone.