Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response (HTTP) status codes for protocol handlers #35

Closed
Gozala opened this issue Jul 23, 2018 · 1 comment
Closed

Response (HTTP) status codes for protocol handlers #35

Gozala opened this issue Jul 23, 2018 · 1 comment
Labels
Protocol Protocol API related issues

Comments

@Gozala
Copy link
Contributor

Gozala commented Jul 23, 2018

This is followup for #2 where you can find all details and context. Below is a quote summarizing it

Response (HTTP) status codes - Turns out nsIHttpChannel reports that by passing nsresult as statusCode parameter to onStopRequest of nsIStreamListener which was passed to channel's asyncOpen. I've asked necko team to point me to the source that does mapping between HTTP status codes and nsresult codes and once I have that it should be fairly easy to support status codes. Please note that very likely things like redirects caching and alike won't just magically start doing right things, most likely those don't have corresponding nsresult it's just implementation of protocol handler does the right thing there instead, which is to say doing caching is on the protocol implementer. Not sure about redirects I'm inclining to just let protocol handler return response with different url and data stream than requested as it would reduce messaging overhead but we'll see after there's more clearance on 1. Async Redirects.

@Gozala Gozala added the Protocol Protocol API related issues label Jul 23, 2018
@Gozala
Copy link
Contributor Author

Gozala commented Aug 7, 2019

@Gozala Gozala closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Protocol Protocol API related issues
Projects
None yet
Development

No branches or pull requests

1 participant