mercurial: fix the case insensitive matching when handling retry errors (#103)

Author: suhaibmujahid

libmozevent/mercurial.py

@@ -313,6 +313,15 @@ class MercurialWorker(object):
     Mercurial worker maintaining several local clones
     """
 
+    ELIGIBLE_RETRY_ERRORS = [
+        error.lower()
+        for error in [
+            "push failed on remote",
+            "stream ended unexpectedly",
+            "error: EOF occurred in violation of protocol",
+        ]
+    ]
+
     def __init__(self, queue_name, queue_phabricator, repositories, skippable_files=[]):
         assert all(map(lambda r: isinstance(r, Repository), repositories.values()))
         self.queue_name = queue_name
@@ -401,15 +410,10 @@ def is_eligible_for_retry(self, error):
         Given a Mercurial error message, if it's an error likely due to a
         temporary connection problem, consider it as eligible for retry.
         """
-        eligible_errors = [
-            "push failed on remote",
-            "stream ended unexpectedly",
-            "error: EOF occurred in violation of protocol",
-        ]
-        for eligible_message in eligible_errors:
-            if eligible_message in error:
-                return True
-        return False
+        error = error.lower()
+        return any(
+            eligible_message in error for eligible_message in self.ELIGIBLE_RETRY_ERRORS
+        )
 
     async def handle_build(self, repository, build):
         """
@@ -471,7 +475,7 @@ async def handle_build(self, repository, build):
             if isinstance(error_log, bytes):
                 error_log = error_log.decode("utf-8")
 
-            if self.is_eligible_for_retry(error_log.lower()):
+            if self.is_eligible_for_retry(error_log):
                 build.retries += 1
                 # Ensure try is opened
                 await self.wait_try_available()