Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading questions asked counter if a moderated event was archived and had some questions rejected or still pending approval #439

Closed
emilghittasv opened this issue Jan 17, 2024 · 1 comment
Assignees

Comments

@emilghittasv
Copy link

emilghittasv commented Jan 17, 2024

Steps to reproduce
Steps to reproduce the behavior:

  1. Sign in to https://moderator.allizom.org/ with an admin account.
  2. Access the https://moderator.allizom.org/event/new page.
  3. Check the "Should this be a moderated event?" checkbox and click on the "save" button.
  4. Leave 3 questions to the posted event: One approved, one rejected and one pending approval.
  5. Click on the event's edit button.
  6. Check the "Should this event be archived?" option and click the "save" button.
  7. Navigate to the https://moderator.allizom.org/archives page and observe the question counter.

Expected behavior
The question counter resembles only the number of approved questions.

Actual behavior
The question counter resembles the total number of questions (approved, rejected and pending approval). Clicking on the event in order to see the questions will reveal only the approved one.

Screencasts
archivedQuestionCounter

┆Issue is synchronized with this Jira Story

@akatsoulas akatsoulas self-assigned this Feb 14, 2024
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Feb 14, 2024
@akatsoulas akatsoulas moved this from ❓ triage to 🚀 in progress in Mozilla Support Feb 14, 2024
@akatsoulas akatsoulas moved this from 🚀 in progress to 🔎 QA in Mozilla Support Feb 14, 2024
@github-project-automation github-project-automation bot moved this from 🔎 QA to ✔ done in Mozilla Support Feb 14, 2024
@akatsoulas akatsoulas moved this from ✔ done to 🔎 QA in Mozilla Support Feb 14, 2024
@akatsoulas akatsoulas reopened this Feb 14, 2024
@emilghittasv
Copy link
Author

I can confirm that this issue is verified fixed in stage.

The question counter resembles only the approved questions inside the https://moderator.allizom.org/archives page. Unarchiving the event will display the correct total number of approved, pending and rejected questions counter again.

Moving this ticket inside the release column.

@emilghittasv emilghittasv moved this from 🔎 QA to 🚢 release in Mozilla Support Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants