Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release neqo v0.8.2 #2040

Closed
mxinden opened this issue Aug 5, 2024 · 6 comments · Fixed by #2045
Closed

Release neqo v0.8.2 #2040

mxinden opened this issue Aug 5, 2024 · 6 comments · Fixed by #2045

Comments

@mxinden
Copy link
Collaborator

mxinden commented Aug 5, 2024

Any objections to me "uplifting" a new neqo version into mozilla-central? Since #2025 I should have permissions to do so myself.

@KershawChang
Copy link
Collaborator

I would like to enable ECN support on Firefox Nightly. For that I need #1964.

Any objections to me "uplifting" a new neqo version into mozilla-central? Since #2025 I should have permissions to do so myself.

No objections. Thanks for doing this!

@mxinden
Copy link
Collaborator Author

mxinden commented Aug 5, 2024

I assume it is as easy as:

  1. Bump the workspace version in the root ./Cargo.toml through a pull request.
  2. Once merged, tag the merge (or squash) commit and push the tag.
  3. Vendor in mozilla-central as https://phabricator.services.mozilla.com/D217271 did via version bump and ./mach vendor rust.

Am I missing something @KershawChang?

@KershawChang
Copy link
Collaborator

I assume it is as easy as:

1. Bump the workspace `version` in the root `./Cargo.toml` through a pull request.

2. Once merged, tag the merge (or squash) commit and push the tag.

Note that when creating a new tag, I always select Set as a pre-release , but I think it doesn't matter.

3. Vendor in mozilla-central as https://phabricator.services.mozilla.com/D217271 did via version bump and `./mach vendor rust`.

Am I missing something @KershawChang?

Yeah, that's all the steps.
Thanks.

@mxinden
Copy link
Collaborator Author

mxinden commented Aug 6, 2024

For the record, mozilla-central uplift: https://phabricator.services.mozilla.com/D218637

@mxinden
Copy link
Collaborator Author

mxinden commented Aug 7, 2024

Note that when creating a new tag, I always select Set as a pre-release , but I think it doesn't matter.

I tagged as pre-release. Though I don't understand why. Given that releases are used in production, i.e. Firefox, why tag them as pre-release? I suggest not doing so for future releases. Objections @KershawChang?

@KershawChang
Copy link
Collaborator

Note that when creating a new tag, I always select Set as a pre-release , but I think it doesn't matter.

I tagged as pre-release. Though I don't understand why. Given that releases are used in production, i.e. Firefox, why tag them as pre-release? I suggest not doing so for future releases. Objections @KershawChang?

Good point. We can use releases in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants