Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors from multiple layers #757

Closed
agrover opened this issue Jun 22, 2020 · 4 comments
Closed

Errors from multiple layers #757

agrover opened this issue Jun 22, 2020 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@agrover
Copy link
Contributor

agrover commented Jun 22, 2020

In a meeting the issue was raised: How should we interpret errors that can come from multiple layers?

For example, InvalidStreamId can come from neqo-qpack but also neqo-transport, and may need to be treated differently depending on which one raised the error.

@agrover agrover added the question Further information is requested label Jun 22, 2020
@ddragana
Copy link
Contributor

I will write down some documentation about how some API functions propagate through different layers and what will be the best way to handle errors.

@ddragana
Copy link
Contributor

ddragana commented Jul 8, 2020

PR that came out of this task:
PR #769 , PR #770 , PR #800 , PR #801 , PR #802 , PR #803 , PR #805
and Issue #804

I have decided to document errors in the code and also add assertion where it was needed. The PRs above are documenting and fixing issues with the error handling in http3(mostly) and in transport code.

@agrover
Copy link
Contributor Author

agrover commented Jul 14, 2020

@ddragana is this issue complete or still in progress? Thanks.

@ddragana
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants