Fix test coverage #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale in this change is to put logic as less as possible in .travis.yml since it's not testable on developers' system.
|
Changes Unknown when pulling 07c03b0 on madarche:fix-test_coverage into * on mozilla:master*. |
|
Finally got that coverage badge working. @zaach could you merge this PR please? Thanks! |
|
Now let's strive for 100% coverage instead of "just" 88% :-) |
|
@zaach could you merge this PR please? This is really an easy one to review. Just tests. No risks :-) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale in this change is to put logic as less as possible in
.travis.ymlbecause it's not testable on developers' system.Also getting rid of istanbul because blanket can do the job both on developers' system and on the Travis platform since blanket@1.1.7 which includes the fix Fix alternative node.js runtimes for mocha.