[WIP] Download required linked PDFs only

Author: timvandermeij

test/integration/annotation_spec.mjs

@@ -169,7 +169,6 @@ describe("Checkbox annotation", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait("bug1847733.pdf", getAnnotationSelector("18R"));
     });
 

test/integration/autolinker_spec.mjs

@@ -219,7 +219,6 @@ describe("autolinker", function () {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait(
         "issue3115r.pdf",
         ".annotationLayer",

test/integration/find_spec.mjs

@@ -90,7 +90,6 @@ describe("find bar", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait("xfa_imm5257e.pdf", ".xfaLayer");
     });
 

test/integration/freetext_editor_spec.mjs

@@ -2381,7 +2381,6 @@ describe("FreeText Editor", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait("bug1823296.pdf", ".annotationEditorLayer");
     });
 

test/integration/highlight_editor_spec.mjs

@@ -800,7 +800,6 @@ describe("Highlight Editor", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait(
         "issue12233.pdf",
         ".annotationEditorLayer",

test/integration/scripting_spec.mjs

@@ -813,7 +813,6 @@ describe("Interaction", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait("issue13132.pdf", getSelector("171R"));
     });
 
@@ -1277,7 +1276,6 @@ describe("Interaction", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait("bug1766987.pdf", getSelector("75R"));
     });
 
@@ -1985,7 +1983,6 @@ describe("Interaction", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait("issue16863.pdf", getSelector("334R"));
     });
 
@@ -2125,7 +2122,6 @@ describe("Interaction", () => {
     let pages;
 
     beforeEach(async () => {
-      pending("Linked PDFs are not supported.");
       pages = await loadAndWait("bug1860602.pdf", getSelector("22R"));
     });
 

test/test.mjs

@@ -410,18 +410,21 @@ function handleSessionTimeout(session) {
   closeSession(browser);
 }
 
-function getTestManifest() {
+function getTestManifest(label = null) {
   var manifest = JSON.parse(fs.readFileSync(options.manifestFile));
 
   const testFilter = options.testfilter.slice(0),
     xfaOnly = options.xfaOnly;
-  if (testFilter.length || xfaOnly) {
+  if (label || testFilter.length || xfaOnly) {
     manifest = manifest.filter(function (item) {
       var i = testFilter.indexOf(item.id);
       if (i !== -1) {
         testFilter.splice(i, 1);
         return true;
       }
+      if (label && item.labels?.includes(label)) {
+        return true;
+      }
       if (xfaOnly && item.enableXfa) {
         return true;
       }
@@ -1084,8 +1087,8 @@ async function closeSession(browser) {
   }
 }
 
-async function ensurePDFsDownloaded() {
-  const manifest = getTestManifest();
+async function ensurePDFsDownloaded(label = null) {
+  const manifest = getTestManifest(label);
   await downloadManifestFiles(manifest);
   try {
     await verifyManifestFiles(manifest);
@@ -1119,6 +1122,8 @@ async function main() {
     } else if (options.fontTest) {
       await startUnitTest("/test/font/font_test.html", "font");
     } else if (options.integration) {
+      // Allows linked PDF files in integration-tests as well.
+      await ensurePDFsDownloaded("integration");
       await startIntegrationTest();
     } else {
       await startRefTest(options.masterMode, options.reftest);

test/test_manifest.json

@@ -1028,7 +1028,8 @@
     "type": "eq",
     "link": true,
     "lastPage": 1,
-    "about": "The same file as issue2337."
+    "about": "The same file as issue2337.",
+    "labels": ["integration"]
   },
   {
     "id": "freeculture",
@@ -2073,7 +2074,8 @@
     "rounds": 1,
     "link": true,
     "enableXfa": true,
-    "type": "eq"
+    "type": "eq",
+    "labels": ["integration"]
   },
   {
     "id": "xfa_bug1716380",
@@ -5143,7 +5145,8 @@
     "file": "pdfs/issue13132.pdf",
     "md5": "1b28964b9188047bc6c786302c95029f",
     "link": true,
-    "type": "other"
+    "type": "other",
+    "labels": ["integration"]
   },
   {
     "id": "issue11518",
@@ -8472,7 +8475,8 @@
     "link": true,
     "rounds": 1,
     "type": "eq",
-    "forms": true
+    "forms": true,
+    "labels": ["integration"]
   },
   {
     "id": "issue12233-print",
@@ -9087,7 +9091,8 @@
     "md5": "3ce134ead03d6158c3e8207453dcd21d",
     "rounds": 1,
     "link": true,
-    "type": "other"
+    "type": "other",
+    "labels": ["integration"]
   },
   {
     "id": "issue14301",
@@ -9975,7 +9980,8 @@
     "file": "pdfs/bug1823296.pdf",
     "md5": "f71e89ebe3d6e75e0c83ce41cd72df1f",
     "link": true,
-    "type": "other"
+    "type": "other",
+    "labels": ["integration"]
   },
   {
     "id": "bug1942064",
@@ -10419,7 +10425,8 @@
     "md5": "d2e167216493a50f732b4b3685a91792",
     "rounds": 1,
     "link": true,
-    "type": "other"
+    "type": "other",
+    "labels": ["integration"]
   },
   {
     "id": "protected-stamp-editor-save-print",
@@ -10455,7 +10462,8 @@
     "file": "pdfs/issue16863.pdf",
     "md5": "af8abe281721f92a0d46646969f061de",
     "link": true,
-    "type": "other"
+    "type": "other",
+    "labels": ["integration"]
   },
   {
     "id": "bug1851498",
@@ -10489,7 +10497,8 @@
     "firstPage": 2,
     "lastPage": 2,
     "type": "eq",
-    "forms": true
+    "forms": true,
+    "labels": ["integration"]
   },
   {
     "id": "issue17169",